Making the core and apps GO types compatible with kubebuilder-based CRD generation #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... to allow `controller-gen` to generate CRDs in `core` and `apps` groups Signed-off-by: David Festal <[email protected]>
... in `core` and `apps` groups, in order to have them to generate corresponding `patchStrategy` and `patchMergeKey` kubernetes extensions in openapiv2 definitions generated from CRDs (when legacy scheme resources are generated from CRDs) Signed-off-by: David Festal <[email protected]>
... since they are used as `patchMergeKey` and in the newly-added `listMapKeys` Signed-off-by: David Festal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Draft PR isn't expected to be merged, but is a reference of what has to be changed in the legacy scheme
core/v1andapps/v1GO type definitions in order to allow generating, with thekubebuildercontroller-gentool, CRDs that can be successfully applied to a minimal apiserver likeKCP.This also required adding
listTypeandlistMapKeysannotations at all the places wherepatchStrategyand/orpatchMergeKeywere used, in order to have them correctly set when generating correspondingpatchStrategyand
patchMergeKeykubernetes extensions in openapiv2 definitions generated from CRDs(when legacy scheme resources are generated from CRDs) (see this change )
Having all the expected
patchStrategyandpatchMergeKeyannotations in the CRD generated openapiV2 schemais critical to enable Strategic Merge Patch for custom resources.
An example of CRDs generated by
kubebuildercontroller-genbased on these changes can be found in PR 4 in thekcpGH repository.