Add a dedicated package manager for yum.

kdeldycke · Apr 25, 2022 · 69f5f8b · 69f5f8b
1 parent 8104b3b
commit 69f5f8b
Show file tree

Hide file tree

Showing 6 changed files with 14 additions and 3 deletions.
diff --git a/changelog.md b/changelog.md
@@ -9,6 +9,7 @@ This version is not released yet and is under active development.
 - \[zypper\] Add `zypper` support for Suse and OpenSuse. Closes {issue}`566`.
 - \[emerge\] Add `emerge` support.
 - \[steamcmd\] Add `steamcmd` support. Refs {issue}`10`.
+- \[yum\] Add dedicated `yum` package manager. Refs {issue}`415`.
 - \[bar-plugin\] Add new `DEFAULT_FONT` and `MONOSPACE_FONT` variable.
 - \[bar-plugin\] Rename all reference of `xbar` to the generic `bar-plugin` label.
 - \[bar-plugin\] Improve search for Python and `mpm` executable.
@@ -62,7 +63,7 @@ This version is not released yet and is under active development.
 ## {gh}`4.12.0 (2022-04-04) <compare/v4.11.0...v4.12.0>`
 
 - \[dnf\] Add support for `dnf`. Closes {issue}`516`, refs {issue}`415`.
-- \[dnf\] Allow `yum` to act as `dnf`. Closes {issue}`415`.
+- \[yum\] Allow `yum` to act as `dnf`. Closes {issue}`415`.
 - \[brew,cask\] Fix execution of `sync` command.
 - \[mpm\] Fix extraction of version. Closes {issue}`536`.
 

diff --git a/meta_package_manager/managers/dnf.py b/meta_package_manager/managers/dnf.py
@@ -34,7 +34,7 @@ class DNF(PackageManager):
 
     requirement = "4.0.0"
 
-    cli_names = ("dnf", "yum")
+    cli_names = ("dnf",)
 
     """
     .. code-block:: shell-session
@@ -200,3 +200,9 @@ def cleanup(self):
         """
         self.run_cli("--assumeyes", "autoremove", sudo=True)
         self.run_cli("clean", "all")
+
+
+class YUM(DNF):
+    """yum is dnf is yum"""
+
+    cli_names = ("yum",)
diff --git a/meta_package_manager/tests/test_cli_install.py b/meta_package_manager/tests/test_cli_install.py
@@ -62,6 +62,7 @@ def test_no_package_id(self, invoke):
         "steamcmd": "",
         "vscode": "tamasfe.even-better-toml",
         "yarn": "markdown",
+        "yum": "usd",
         "zypper": "git",
     }
     assert set(PACKAGE_IDS) == set(pool.all_manager_ids)

diff --git a/meta_package_manager/tests/test_pool.py b/meta_package_manager/tests/test_pool.py
@@ -25,7 +25,7 @@
 
 def test_manager_count():
     """Check all implemented package managers are accounted for, and unique."""
-    assert len(pool) == 21
+    assert len(pool) == 22
     assert len(pool) == len(pool.all_manager_ids)
     assert pool.all_manager_ids == tuple(sorted(set(pool)))
 

diff --git a/pyproject.toml b/pyproject.toml
@@ -44,6 +44,7 @@ keywords = [
     'xbar',
     'swiftbar',
     'yarn',
+    'yum',
     'zypper',
 ]
 classifiers = [

diff --git a/readme.md b/readme.md
@@ -73,6 +73,7 @@ ______________________________________________________________________
 | [`steamcmd`](https://developer.valvesoftware.com/wiki/SteamCMD)           | None         |   🍎   |   🐧   |    🪟    |             |            |                                                                       |     ✓     |     ✓     |        |           |
 | [`vscode`](https://code.visualstudio.com)                                 | 1.60.0       |   🍎   |   🐧   |    🪟    |      ✓      |            |                                   ✓                                   |     ✓     |           |        |           |
 | [`yarn`](https://yarnpkg.com)                                             | 1.21.0       |   🍎   |   🐧   |    🪟    |      ✓      |     ✓      |                                   ✓                                   |     ✓     |     ✓     |        |     ✓     |
+| [`yum`](http://yum.baseurl.org)                                           | 4.0.0        |       |   🐧   |         |      ✓      |     ✓      |                                   ✓                                   |     ✓     |     ✓     |   ✓    |     ✓     |
 | [`zypper`](https://en.opensuse.org/Portal:Zypper)                         | 1.14.0       |       |   🐧   |          |     ✓     |     ✓      |                                      ✓                                   |     ✓     |       ✓   |     ✓ |    ✓     |
 
 ## Quickstart
@@ -117,6 +118,7 @@ $ mpm --all-managers managers
 │ SteamCMD           │ steamcmd │ ✓              │ ✓ /opt/local/bin/steamcmd │ ✓          │ ✓ 1648077083 │
 │ Visual Studio Code │ vscode   │ ✓              │ ✓ /usr/local/bin/code     │ ✓          │ ✓ 1.61.0     │
 │ Node's yarn        │ yarn     │ ✓              │ ✘ yarn not found          │            │              │
+│ YUM                │ yum      │ ✘ Linux only   │ ✘ yum not found           │            │              │
 │ Zypper             │ zypper   │ ✘ Linux only   │ ✘ zypper not found        │            │              │
 ╰────────────────────┴──────────┴────────────────┴───────────────────────────┴────────────┴──────────────╯
 ```
-Original file line number
+Diff line change
@@ Expand Up / @@ -44,6 +44,7 @@ keywords = [ @@
         'xbar',
         'swiftbar',
         'yarn',
+        'yum',
         'zypper',
     ]
     classifiers = [
@@ Expand Down @@