fix: default version in description #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Problem
The details for description are:
```text
Project description used in title (if empty, uses neovim version and current date)
```
However this currently does not work, instead the version section of the
description is left empty.
## Solution
The reason this occurs is `vimversion` is set to empty by default:
```bash
"--metadata=vimversion:${VIM_VERSION:-""}"
```
However the check compares the value to `nil`.
Added a helper `empty` function that checks if the value is `nil` or if
the length is 0. Used when checking `vim_version` & `project_description`.
kdheepak
approved these changes
Apr 29, 2025
Owner
|
Thank you for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The details for description are:
However this currently does not work, instead the version section of the description is left empty.
Solution
The reason this occurs is
vimversionis set to empty by default:"--metadata=vimversion:${VIM_VERSION:-""}"However the check compares the value to
nil.Added a helper
emptyfunction that checks if the value isnilor if the length is 0. Used when checkingvim_version&project_description.Testing
Ran on my plugin's README:
Description Before:
Description After: