Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make note of changes to macOS leveldb install. #296

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JosephShenton
Copy link

No description provided.

Copy link
Owner

@kdrag0n kdrag0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, just a minor detail to fix.

@@ -45,6 +45,9 @@ install that first. Below are instructions for some common operating systems:
| Termux | `apt install leveldb` |
| FreeBSD | `pkg install leveldb` |

> At the time of writing this note, macOS's package installer *brew* requires a different command to install leveldb.
`brew install --build-from-source leveldb`
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please edit the macOS command to add this argument instead. It can be reverted if/when the upstream issue is fixed rather than adding a separate note. Don't worry about alignment in the table for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants