Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logout functionality and guards behavior #138

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hootanht
Copy link

@hootanht hootanht commented Jun 30, 2024

Related to #14

Implements an alternative solution for logging out without closing browser tabs, and enhances authentication guards.

  • Authentication Service: Modifies the loginOut method to clear local storage and navigate to the login page instead of reloading the window. This change ensures a smoother logout process without closing the browser tab.
  • Authentication Guard: Updates the canActivate method to check for the existence of an 'auth_token' in local storage and redirects to the login page if not found. This strengthens the security by ensuring that navigation is only allowed for authenticated users.
  • UnAuthentication Guard: Adjusts the canActivate method to redirect authenticated users to the home page, preventing access to authentication-related pages for users who are already logged in.
  • Logout Component: Changes the logout logic to navigate to the login page after logging out, ensuring users are redirected appropriately.
  • Unit Tests: Adds and updates unit tests for the AuthenticationService and guards to cover the new logout behavior and guard functionality, ensuring the changes work as expected.

For more details, open the Copilot Workspace session.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant