Support for Azure Default Credentials in the Scaler #68
Conversation
Signed-off-by: Piotr Karpala <[email protected]>
Signed-off-by: Piotr Karpala <[email protected]>
Signed-off-by: Piotr Karpala <[email protected]>
Signed-off-by: Piotr Karpala <[email protected]>
Signed-off-by: Piotr Karpala <[email protected]>
| @@ -25,7 +26,11 @@ public Worker(CosmosDbConfig cosmosDbConfig, ILogger<Worker> logger) | |||
|
|
|||
| public override async Task StartAsync(CancellationToken cancellationToken) | |||
| { | |||
| Database leaseDatabase = await new CosmosClient(_cosmosDbConfig.LeaseConnection) | |||
| var cosmosClient = _cosmosDbConfig.Connection.Contains("AccountKey") | |||
There was a problem hiding this comment.
Hi @karpikpl, the PR looks good overall. This particular cosmosClient should be based on LeaseConnection configuration as the sample code aims to work even when the Cosmos DB accounts are different for the monitored and lease containers. I have a couple of minor changes planned and should be able to fix this one too in the new PR if that's okay with you.
I have a few questions on AAD identity-based access. Would be helpful if you have answer to some or all of them.
- Were you able to test the demo code with default credentials? I had tough time trying to set the permissions as none of the existing role (and with custom role) seem to give me access to create database, etc.
- Do we have steps to allow use of default credentials inside locally running Docker container?
- Do we know the minimum (or a superset of) permissions required by the Cosmos DB scaler to be able to check change feeds and generate necessary KEDA metrics? If so, I can document and publish it in this repo.
There was a problem hiding this comment.
@karpikpl - Reminder on this one. Let me know if you know answers to any of the questions.
There was a problem hiding this comment.
@JatinSanghvi I am highly interested in this one as well.
Were you able to test the demo code with default credentials? I had tough time trying to set the permissions as none of the existing role (and with custom role) seem to give me access to create database, etc.
Do you want me to take a stab at this?
You would most likely need a control plane role here:
Do we have steps to allow use of default credentials inside locally running Docker container?
I believe you would use Account Key based authentication there - there's no robust need or support for that imo.
Do we know the minimum (or a superset of) permissions required by the Cosmos DB scaler to be able to check change feeds and generate necessary KEDA metrics? If so, I can document and publish it in this repo.
here's a link to the built-in data plane roles
I believe you are looking for: Microsoft.DocumentDB/databaseAccounts/sqlDatabases/containers/readChangeFeed
Support for Azure Default Credentials in the Scaler
Checklist
Fixes #49