Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Support for FromEnv properties for Connections #76

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

Sreemoyee26
Copy link

@Sreemoyee26 Sreemoyee26 commented Dec 4, 2024

We have replaced connection and leaseconnection properties with connectionFromEnv and leaseConnectionFromEnv properties in scalermetadata. Inspite of giving the connection string directly the customer can now specify the environment variable name for connectionFromEnv and give the connection strings as environment variables.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)
  • A PR is opened to update the documentation on our docs repo

Fixes #

  • Added connectionFromEnv and leaseConnectionFromEnv as json property name for connection and Leaseconnection.
  • Changed the UTs to test this
  • Updated the scaledobject yaml files and Demo Project Readme to test out these changes.

README.md Outdated Show resolved Hide resolved
@Sreemoyee26 Sreemoyee26 changed the title Adding Support for Functions on ACA Adding Support for FromEnv properties for Connections Dec 9, 2024
Copy link
Collaborator

@JatinSanghvi JatinSanghvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please hold before addressing the review comments as we need to think whether to remove support for connection property entirely from the next version of scaler image.

README.md Outdated Show resolved Hide resolved
src/Scaler.Tests/CosmosDbScalerServiceTests.cs Outdated Show resolved Hide resolved
deploy/deploy-scaledobject.yaml Show resolved Hide resolved
src/Scaler/Services/ScalerMetadata.cs Outdated Show resolved Hide resolved
src/Scaler/Services/ScalerMetadata.cs Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
deploy/deploy-scaledobject.yaml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/Scaler/Services/ScalerMetadata.cs Outdated Show resolved Hide resolved
src/Scaler/Services/ScalerMetadata.cs Outdated Show resolved Hide resolved
src/Scaler/Services/ScalerMetadata.cs Outdated Show resolved Hide resolved
src/Scaler/Services/ScalerMetadata.cs Outdated Show resolved Hide resolved
src/Scaler.Tests/CosmosDbScalerServiceTests.cs Outdated Show resolved Hide resolved
Copy link
Contributor

@krishnajaju krishnajaju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants