-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Support for FromEnv properties for Connections #76
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please hold before addressing the review comments as we need to think whether to remove support for connection
property entirely from the next version of scaler image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We have replaced connection and leaseconnection properties with connectionFromEnv and leaseConnectionFromEnv properties in scalermetadata. Inspite of giving the connection string directly the customer can now specify the environment variable name for connectionFromEnv and give the connection strings as environment variables.
Checklist
Fixes #