feat: New ScalingSet CRD to deploy isolated interceptors+scalers #1014

JorTurFer · 2024-05-05T00:27:06Z

Provide a description of what has been changed

Checklist

Commits are signed with Developer Certificate of Origin (DCO)
Changelog has been updated and is aligned with our changelog requirements
Any necessary documentation is added, such as:

Fixes #241

wozniakjan

I like this approach very much, here is a couple of minor nitpicks from the first pass, I will take a deeper look later today

operator/apis/http/v1alpha1/httpscalingset_types.go

operator/controllers/http/clusterhttpscalingset_controller.go

zroubalik

First pass of review

zroubalik · 2024-05-16T08:52:36Z

operator/apis/http/v1alpha1/httpscalingset_types.go

+}
+
+// HTTPScalingSetStatus defines the observed state of HTTPScalingSet
+type HTTPScalingSetStatus struct{}


We should provide some status about the resource, at least Ready condition

zroubalik · 2024-05-16T08:55:34Z

operator/controllers/http/scaler.go

+	ctx context.Context,
+	logger logr.Logger,
+	cl client.Client,
+	httpss metav1.Object,


We should consider using duck types instead of metav1.Object here, to add some type safety.

@wozniakjan has also an idea on this.

WDYM? We do almost the same in KEDA with ScaledObjects and ScaledJobs. Would be enough if I validate the type and return an error if the type isn't correct?

I mentioned to @zroubalik earlier that maybe we could explore type aliasing or trivial type definitions. In this case, both ScalingSets as well as ClusterScalingSets seem to have exactly matching structure so maybe we could do something along the lines of either

type ClusterScalingSet ScalingSet

or

type ClusterScalingSet = ScalingSet

I had used the first one with controller-runtime v1 some eons ago successfully and haven't tried it ever since, but could be a good fit for this usecase unless controller-runtime became more strict regarding types.

The implementation went something like this: https://go.dev/play/p/sxZiO_BDw4z

I didn't know that this works with kubebuilder but I can give a try because yes. both types are exactly the same, just cluster scoped or namespaced

pkg/util/scalingset_validatior.go

JorTurFer · 2024-05-16T09:04:54Z

I appreciate your feedback, I'll review it, but don't worry about reviewing the PR for the moment as it's still a WIP and there are a couple of pending stuff, like propagating the status info the the CRD, documentation, more test coverage , etc

You can review it if you want, but there can be multiple changes until the final version :)

operator/controllers/http/scaler.go

operator/controllers/http/clusterhttpscalingset_controller.go

Signed-off-by: Jorge Turrado <[email protected]>

JorTurFer · 2024-06-24T13:46:42Z

I'm removing the changes applied to my local branch

Signed-off-by: Jorge Turrado <[email protected]>

JorTurFer · 2024-06-24T20:11:38Z

I've been talking about this with @zroubalik and to not lock you with the code refactor, we will agreed with merging this PR as it is (it works actually) and I'll open a followup PR in a few days/weeks (before the release for sure) adding the pending stuff to complete this PR (such as but not exclusive):

Documentation
CRD Status propagation
Autoscaling
Support for global configurations (timeouts, TLS, watched namespaces, etc...)

kahirokunn · 2024-10-23T01:40:19Z

This feature is great!
I can't wait to start using it!

kahirokunn · 2024-11-05T05:22:22Z

@wozniakjan Hello!
Is there anything else you need to do to merge this PR?
If you need help, I'd be happy to help.

kahirokunn · 2024-11-07T05:43:46Z

I have prepared a helm chart 👍
kedacore/charts#703

wozniakjan · 2024-12-05T13:00:56Z

@wozniakjan Hello!
Is there anything else you need to do to merge this PR?

@kahirokunn I haven't been monitoring the progress here too closely but it seems there are a few pending items still - #1014 (comment)

kahirokunn · 2024-12-05T14:51:30Z

comment)

I’d like to provide an update and propose a way forward based on the current situation:
1. Current Status
• I have thoroughly tested this PR in my environment, and I can confirm that it works very well as it stands.
• While there are some pending items mentioned in #1014, these do not block the core functionality of this PR, and the PR is in a functional state that meets our immediate needs.
2. Proposal
• Based on the above, I propose we merge this PR in its current form.
• For the remaining tasks, I suggest we take a collaborative approach: we can divide the pending work among the team (myself included) and address these items in a follow-up PR before the release.
3. Benefits
• This approach ensures we make progress without blocking the current work while maintaining our focus on completing the remaining tasks in a timely manner.

Please let me know your thoughts on this proposal, or if there are any concerns about moving forward with this plan!

wozniakjan · 2024-12-13T10:34:25Z

config/operator/role.yaml

+- apiGroups:
+  - ""
+  resources:
+  - services
+  verbs:
+  - create
+  - delete
+  - get
+  - list
+  - patch
+  - update
+  - watch
+- apiGroups:
+  - apps
+  resources:
+  - deployments
+  verbs:
+  - create
+  - delete
+  - get
+  - list
+  - patch
+  - update
+  - watch


I understand why this broad RBAC is added, but it effectively means the addon can do anything to all deployments in the cluster. Is there any chance the scaling sets are optional?

I can imagine a dual deployment workflow configured on the helm chart level

static - a single interceptor+scaler without scalingsets enabled (the current v0.8.0 workflow)

dynamic - enable scalingsets CRD and this broad RBAC

JorTurFer requested a review from a team as a code owner May 5, 2024 00:27

JorTurFer force-pushed the isolated-components branch 2 times, most recently from 4e793d6 to 6e1700a Compare May 12, 2024 19:53

wozniakjan reviewed May 16, 2024

View reviewed changes

zroubalik reviewed May 16, 2024

View reviewed changes

JorTurFer marked this pull request as draft May 16, 2024 09:05

zroubalik reviewed May 16, 2024

View reviewed changes

operator/controllers/http/scaler.go Show resolved Hide resolved

zroubalik reviewed May 16, 2024

View reviewed changes

operator/controllers/http/clusterhttpscalingset_controller.go Outdated Show resolved Hide resolved

JorTurFer and others added 5 commits June 24, 2024 15:44

feat: New ScalingSet CRD to deploy isolated interceptors+scalers

b9cb08c

Signed-off-by: Jorge Turrado <[email protected]>

include ginkgo results into CI report

ccfe166

Signed-off-by: Jorge Turrado <[email protected]>

include functional tests for cluster scoper resource

5ee863d

Signed-off-by: Jorge Turrado <[email protected]>

fix styles

9fd9313

Signed-off-by: Jorge Turrado <[email protected]>

Add some unit tests

ce7ae4e

Signed-off-by: Jorge Turrado <[email protected]>

apply some feedback

6286ab0

Signed-off-by: Jorge Turrado <[email protected]>

JorTurFer force-pushed the isolated-components branch from b58f3f4 to 6286ab0 Compare June 24, 2024 13:57

JorTurFer added 3 commits June 24, 2024 16:13

update manifests

97276b8

Signed-off-by: Jorge Turrado <[email protected]>

style

3665ee9

Signed-off-by: Jorge Turrado <[email protected]>

Remove not used file

1feba4d

Signed-off-by: Jorge Turrado <[email protected]>

JorTurFer marked this pull request as ready for review June 24, 2024 18:23

JorTurFer changed the title ~~WIP - feat: New ScalingSet CRD to deploy isolated interceptors+scalers~~ feat: New ScalingSet CRD to deploy isolated interceptors+scalers Jun 24, 2024

fix test

a9b639a

Signed-off-by: Jorge Turrado <[email protected]>

zroubalik requested a review from wozniakjan June 25, 2024 22:37

wozniakjan mentioned this pull request Oct 22, 2024

[WIP] feat: add label filtering for HTTPScaledObjects #1173

Closed

3 tasks

kahirokunn mentioned this pull request Nov 7, 2024

feat: New ScalingSet CRD to deploy isolated interceptors+scalers kedacore/charts#703

Open

4 tasks

wozniakjan mentioned this pull request Dec 5, 2024

interceptor: Add support for AWS ALB healthcheck probe #1198

Closed

wozniakjan reviewed Dec 13, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: New ScalingSet CRD to deploy isolated interceptors+scalers #1014

feat: New ScalingSet CRD to deploy isolated interceptors+scalers #1014

JorTurFer commented May 5, 2024

wozniakjan left a comment

zroubalik left a comment

zroubalik May 16, 2024

zroubalik May 16, 2024

zroubalik May 16, 2024

JorTurFer Jun 24, 2024

wozniakjan Jun 24, 2024

JorTurFer Jun 24, 2024

JorTurFer commented May 16, 2024

JorTurFer commented Jun 24, 2024

JorTurFer commented Jun 24, 2024

kahirokunn commented Oct 23, 2024

kahirokunn commented Nov 5, 2024

kahirokunn commented Nov 7, 2024

wozniakjan commented Dec 5, 2024

kahirokunn commented Dec 5, 2024

wozniakjan Dec 13, 2024

zroubalik Dec 13, 2024

feat: New ScalingSet CRD to deploy isolated interceptors+scalers #1014

Are you sure you want to change the base?

feat: New ScalingSet CRD to deploy isolated interceptors+scalers #1014

Conversation

JorTurFer commented May 5, 2024

Checklist

wozniakjan left a comment

Choose a reason for hiding this comment

zroubalik left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JorTurFer commented May 16, 2024

JorTurFer commented Jun 24, 2024

JorTurFer commented Jun 24, 2024

kahirokunn commented Oct 23, 2024

kahirokunn commented Nov 5, 2024

kahirokunn commented Nov 7, 2024

wozniakjan commented Dec 5, 2024

kahirokunn commented Dec 5, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment