Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧 docs: Provide improved side-bar structure #1031

Closed
wants to merge 2 commits into from

Conversation

tomkerkhove
Copy link
Member

@tomkerkhove tomkerkhove commented Jan 6, 2023

Provide improved side-bar structure to have a more consistent experience and ordering that follows how people would adopt KEDA (what, deploy, ops, faq).

Current:
image

Proposal:
image

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #

@netlify
Copy link

netlify bot commented Jan 6, 2023

Deploy Preview for keda failed.

Name Link
🔨 Latest commit 4cec452
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/63b82829b232da0009828831

@tomkerkhove
Copy link
Member Author

@kedacore/keda-maintainers This proposal is only for 2.9 because I want to verify we want this new structure before I update all versions.

Thoughts?

@JorTurFer
Copy link
Member

Looks good, how does it look for mobile?

@tomkerkhove tomkerkhove marked this pull request as ready for review January 6, 2023 13:32
@tomkerkhove tomkerkhove requested a review from a team as a code owner January 6, 2023 13:32
@tomkerkhove tomkerkhove changed the title docs: Provide improved side-bar structure 🚧 docs: Provide improved side-bar structure Jan 6, 2023
@tomkerkhove
Copy link
Member Author

Still broken as tracked in ##928

Signed-off-by: Tom Kerkhove <[email protected]>
@tomkerkhove
Copy link
Member Author

@kedacore/keda-maintainers I forgot about this PR - If you like the proposed changes I can re-do them?

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the proposal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants