Fix Cloudwatch documentation suggesting invalid conditions #1462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicolaj Vinholt <[email protected]>
|
Thank you for your contribution! 🙏 We will review your PR as soon as possible.
Learn more about:
|
✅ Deploy Preview for keda ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
zroubalik
reviewed
Nov 5, 2024
There was a problem hiding this comment.
@robpickerill I would love to hear your opinion, seems like you added this part here :)
Relates: #1347
|
This is correct, and my mistake, putmetricdata has a condition, not getmetricdata |
JorTurFer
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a description of what has been changed
The currently documentation incorrectly assumes the ability to scope down KEDA GetMetricData permissions by the use of conditions. However as shown in the official Actions defined by Amazon CloudWatch documentation, GetMetricData does not support any condition keys.
Checklist