Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added datadogMetricsService and fix datadogNamespace key in triggerAu… #1469

Merged
merged 9 commits into from
Nov 5, 2024

Conversation

alvarobacelar
Copy link

Included datadogMetricsService and fixed datadogNamespace key in triggerAuthenticatio specs. When I have been Tried this configurations I got errors. After I fix this keys, provide in this PR, works well.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #

@alvarobacelar alvarobacelar requested a review from a team as a code owner September 17, 2024 18:28
Copy link

netlify bot commented Sep 17, 2024

Deploy Preview for keda ready!

Name Link
🔨 Latest commit b9b49f0
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/671c1609b1f4ac000838bc62
😎 Deploy Preview https://deploy-preview-1469--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@zroubalik
Copy link
Member

Thanks, duplicate of: #1451

@zroubalik zroubalik closed this Sep 18, 2024
@alvarobacelar
Copy link
Author

@zroubalik zroubalik reopened this Sep 18, 2024
@zroubalik
Copy link
Member

@alvarobacelar thanks, haven't notice that. Could you please rebase this PR ?

Alvaro Bacelar added 2 commits September 18, 2024 22:12
@alvarobacelar
Copy link
Author

@zroubalik I've been done.

@alvarobacelar
Copy link
Author

Hi @zroubalik. is it everything ok with this PR?

@alvarobacelar
Copy link
Author

Hello, @JorTurFer.
I think this PR it's ok.
Could you please review it?

@alvarobacelar
Copy link
Author

@zroubalik what happened with this PR?
Is there something wrong? Please let me know if there’s anything wrong.

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @alvarobacelar !

Sorry for the delay, a lot of stuff on my backlog :)

@zroubalik zroubalik merged commit 1d574a5 into kedacore:main Nov 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants