Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Commit

Permalink
Merge pull request #10 from tomkerkhove/switch-dockerhub-accounts
Browse files Browse the repository at this point in the history
Change 'tsuyoshiushio/durableexternalscaler' to 'kedacore/keda-scaler-durable-functions'
  • Loading branch information
TsuyoshiUshio authored Jan 29, 2020
2 parents 26d5230 + bfb4dc5 commit b63d6f5
Show file tree
Hide file tree
Showing 8 changed files with 12 additions and 12 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ KEDA Durable Functions Scaler works as a gRPC server of the [External Scaler Sup
Currently, KEDA Durable Scaler can't make functions scale down to zero. Minimum pod number is one. Durable Scaler need to send data to control/worker queue. For achieve this behavior, we need to separate the HTTP and non-HTTP deployments. However, the feature seems not working. We need to wait until this issue is fixed.

* [Add configuration for enabling only HTTP or only non-HTTP functions #4412](https://github.com/Azure/azure-functions-host/issues/4412)
* [Pods doesn't scale in to zero #17](https://github.com/microsoft/keda-durable-scaler/issues/17)
* [Pods doesn't scale in to zero #17](https://github.com/kedacore/keda-scaler-durable-functions/issues/17)

## Getting Started & Documentation

Expand Down
4 changes: 2 additions & 2 deletions deploy/build_push_image.sh
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/bin/bash

cd ..
docker build . -t tsuyoshiushio/durableexternalscaler:latest -t tsuyoshiushio/durableexternalscaler:0.1
docker push tsuyoshiushio/durableexternalscaler
docker build . -t kedacore/keda-scaler-durable-functions:latest -t kedacore/keda-scaler-durable-functions:0.1
docker push kedacore/keda-scaler-durable-functions
cd deploy
2 changes: 1 addition & 1 deletion deploy/deployment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ spec:
spec:
serviceAccountName: keda-durable-scaler
containers:
- image: tsuyoshiushio/durableexternalscaler:latest
- image: kedacore/keda-scaler-durable-functions:latest
name: scaler
ports:
- containerPort: 5000
Expand Down
6 changes: 3 additions & 3 deletions docs/developers-guide.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,15 +66,15 @@ You can refer [Getting Started](getting-started.md) to create and configure cert

For reading this code, there is several important files are there.

#### [ExternalScalerService](https://github.com/microsoft/keda-durable-scaler/blob/master/src/Keda.Durable.Scaler.Server/Services/ExternalScalerService.cs)
#### [ExternalScalerService](https://github.com/kedacore/keda-scaler-durable-functions/blob/master/src/Keda.Durable.Scaler.Server/Services/ExternalScalerService.cs)

Core logic of the scaling. This class implement scaler logic of this server. It uses, [DurableTask.DisconnectPerformanceMonitor](https://github.com/Azure/durabletask/blob/master/src/DurableTask.AzureStorage/Monitoring/DisconnectedPerformanceMonitor.cs#L89) for getting analytics data nad telemetry.

#### [externalscaler.proto](https://github.com/microsoft/keda-durable-scaler/blob/master/src/Keda.Durable.Scaler.Server/Protos/externalscaler.proto)
#### [externalscaler.proto](https://github.com/kedacore/keda-scaler-durable-functions/blob/master/src/Keda.Durable.Scaler.Server/Protos/externalscaler.proto)

Protocol buffer of the [External Scaler Support for KEDA](https://github.com/kedacore/keda/pull/294). Usually, you might need to generate code from this buffer. It is automatically done by [gRPC services with ASP.NET Core](https://docs.microsoft.com/en-us/aspnet/core/grpc/aspnetcore?view=aspnetcore-3.0&tabs=visual-studio). You can see the generated file under the obj directory, however, you don't need commit these files to the repo.

#### [Startup.cs](https://github.com/microsoft/keda-durable-scaler/blob/master/src/Keda.Durable.Scaler.Server/Startup.cs#L21)
#### [Startup.cs](https://github.com/kedacore/keda-scaler-durable-functions/blob/master/src/Keda.Durable.Scaler.Server/Startup.cs#L21)

It contains DI configration for the server, it also include Enviornment Variables configration for the Server.

Expand Down
2 changes: 1 addition & 1 deletion docs/getting-started.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ $ kubectl apply -f deploy/
Clone the KEDA Durable Scaler repo

```bash
$ git clone [email protected]:microsoft/keda-durable-scaler.git
$ git clone [email protected]:kedacore/keda-scaler-durable-functions.git
$ cd keda-durable-scaler
```

Expand Down
2 changes: 1 addition & 1 deletion docs/reference.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ spec:
spec:
serviceAccountName: keda-durable-scaler
containers:
- image: tsuyoshiushio/durableexternalscaler:latest
- image: kedacore/keda-scaler-durable-functions:latest
name: scaler
ports:
- containerPort: 5000
Expand Down
4 changes: 2 additions & 2 deletions examples/durable-keda/build_push_image.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/bin/bash

docker build . -t tsuyoshiushio/durable-keda:latest -t tsuyoshiushio/durable-keda:0.1
docker push tsuyoshiushio/durable-keda
docker build . -t kedacore/durable-keda:latest -t kedacore/durable-keda:0.1
docker push kedacore/durable-keda
2 changes: 1 addition & 1 deletion examples/durable-keda/deployone.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ spec:
spec:
containers:
- name: durable-keda
image: tsuyoshiushio/durable-keda:latest
image: kedacore/durable-keda:latest
ports:
- containerPort: 80
env:
Expand Down

0 comments on commit b63d6f5

Please sign in to comment.