allow to authenticate to Azure Storage using SAS tokens#5382
Merged
zroubalik merged 5 commits intokedacore:mainfrom Jan 18, 2024
Merged
allow to authenticate to Azure Storage using SAS tokens#5382zroubalik merged 5 commits intokedacore:mainfrom
zroubalik merged 5 commits intokedacore:mainfrom
Conversation
Signed-off-by: Martin Dzibela <martin.dzibela@kosik.cz>
1 task
Signed-off-by: Martin Dzibela <martin.dzibela@kosik.cz>
Signed-off-by: Martin Dzibela <martin.dzibela@kosik.cz>
tomkerkhove
approved these changes
Jan 17, 2024
Member
tomkerkhove
left a comment
tomkerkhove
left a comment
There was a problem hiding this comment.
LGTM, can we add an end-to-end test for this?
zroubalik
reviewed
Jan 17, 2024
Member
zroubalik
left a comment
zroubalik
left a comment
There was a problem hiding this comment.
Could you please open a tracking issue for this and link it in the Changelog?
We plan to ship 2.13 tomorrow, if we are able to tackle this by then, then the Changelog entry should be fixed and move from unreleased to 2.13 section
Signed-off-by: Martin Dzibela <martin.dzibela@kosik.cz>
Signed-off-by: Martin Dzibela <martin.dzibela@kosik.cz>
Member
|
/run-e2e |
zroubalik
approved these changes
Jan 18, 2024
Member
zroubalik
left a comment
zroubalik
left a comment
There was a problem hiding this comment.
Unrelated e2e test failures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support to use Shared Access Signature (SAS) authentication in Azure Storage Queue scaler.
Checklist
Fixes #5393
Relates to kedacore/keda-docs#1293