Support multiple queues at the IBMMQ scaler #6182
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickbrouwer
force-pushed
the
issue-6181
branch
from
5a9617c
to
8651e67
Compare
rickbrouwer
force-pushed
the
issue-6181
branch
3 times, most recently
from
593c9db
to
afd816d
Compare
Signed-off-by: rickbrouwer <[email protected]>
rickbrouwer
force-pushed
the
issue-6181
branch
from
afd816d
to
9d2717a
Compare
rickbrouwer
force-pushed
the
issue-6181
branch
5 times, most recently
from
a31b5ed
to
dc66dcc
Compare
Signed-off-by: Rick Brouwer <[email protected]>
Signed-off-by: Rick Brouwer <[email protected]>
rickbrouwer
force-pushed
the
issue-6181
branch
from
dc66dcc
to
d9795c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the
queueNameparameter so that it accepts multiple queues (comma (,) separated). The code is is changed so it's request the current depth per queue and only use the current depth from the queue with the most messages. Because it's accepts multiple queues,queueNameswill be also supported.Also added extra check for authentication error. When an incorrect password is given the error message is
error inspecting IBM MQ queue depth: failed to parse response from REST call. The reason is a bit unclear. That's why I added a better error messageerror inspecting IBM MQ queue depth: authentication failed: incorrect username or password.Checklist
Fixes #6181
Docs: kedacore/keda-docs#1473