Fix testLogBug and changeSomeVariableName #6420
Conversation
Signed-off-by: Shane <[email protected]>
ctccxxd
changed the title
|
Friendly ping @wozniakjan @SpiritZhou @JorTurFer hope you to review and discuss, much thanks. |
| var incomingSvGvkr GroupVersionKindResource | ||
| incomingSvGvkr, err = ParseGVKR(restMapper, incomingSo.Spec.ScaleTargetRef.APIVersion, incomingSo.Spec.ScaleTargetRef.Kind) |
There was a problem hiding this comment.
why Sv instead of So?
Because GVKR represents GroupVersionKindResource, and this is be seen more common and explicit.
There was a problem hiding this comment.
Yeah, Gckr vs Gvkr is clear (and the change is 100% worth), but SO means ScaledObject, that's why my question
There was a problem hiding this comment.
Yeah,
GckrvsGvkris clear (and the change is 100% worth), butSOmeansScaledObject, that's why my question
Haha, an oolong，I have revised. Wait for your review. thanks
go.mod
Outdated
| // https://avd.aquasec.com/nvd/cve-2024-45337 | ||
| golang.org/x/crypto => golang.org/x/crypto v0.31.0 |
There was a problem hiding this comment.
I'd move this to another PR as it's to solve an issue by bumping deps
There was a problem hiding this comment.
I'd move this to another PR as it's to solve an issue by bumping deps
ok
There was a problem hiding this comment.
I've created this PR to bump the dependency as it has a critical CVE -> #6422
There was a problem hiding this comment.
I've created this PR to bump the dependency as it has a critical CVE -> #6422
I have revised here, maybe can directly merge this PR. Otherwise, I have to separate this PR.
There was a problem hiding this comment.
please rebase your PR with main changes 🙏 sorry for this, I prefer to have an isolated PR to fix the CVE because it's a 9.1 that needs to be trackable IMHO
There was a problem hiding this comment.
please rebase your PR with main changes 🙏 sorry for this, I prefer to have an isolated PR to fix the CVE because it's a 9.1 that needs to be trackable IMHO
make sense, both are all ok.
CHANGELOG.md
Outdated
| @@ -75,6 +75,7 @@ Here is an overview of all new **experimental** features: | |||
|
|
|||
| - **General**: Centralize and improve automaxprocs configuration with proper structured logging ([#5970](https://github.com/kedacore/keda/issues/5970)) | |||
| - **General**: Paused ScaledObject count is reported correctly after operator restart ([#6321](https://github.com/kedacore/keda/issues/6321)) | |||
| - **General**: Revise some variable names and wrong test log([#6420](https://github.com/kedacore/keda/pull/6420)) | |||
There was a problem hiding this comment.
Let' move this into Other section - as it is not user facing fix. Or we can even remove it from the changelog. I am okay with both.
There was a problem hiding this comment.
Let' move this into Other section - as it is not user facing fix. Or we can even remove it from the changelog. I am okay with both.
ok
There was a problem hiding this comment.
done, friendly ping @zroubalik @zroubalik , hope for your review, thank you.
Signed-off-by: Shane <[email protected]>
Signed-off-by: Shane <[email protected]>
Signed-off-by: Shane <[email protected]>
ctccxxd
force-pushed
the
changeSomeVariableNameLog
branch
from
8dd5470 to
f56c05b
Compare
|
done, friendly ping @zroubalik @zroubalik , hope for your review, thank you. |
|
/run-e2e internal |
Checklist
Fixes #
Relates to #