-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor gcp stackdriver scaler #6462
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Omer Aplatony <[email protected]>
/run-e2e gcp |
Signed-off-by: Omer Aplatony <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thank you!
minor nits below
just noticed the imports are not sorted the way linter is configured, can you please run following command? (or address the imports sort manually :))
I will retrigger the e2e tests after that |
Co-authored-by: Jan Wozniak <[email protected]> Signed-off-by: Omer Aplatony <[email protected]>
Signed-off-by: Omer Aplatony <[email protected]>
done |
Provide a description of what has been changed
Checklist
Fixes #
Relates to #5797