Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor gcp stackdriver scaler #6462

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

omerap12
Copy link
Contributor

@omerap12 omerap12 commented Jan 2, 2025

Provide a description of what has been changed

Checklist

Fixes #

Relates to #5797

Signed-off-by: Omer Aplatony <[email protected]>
@omerap12 omerap12 requested a review from a team as a code owner January 2, 2025 15:34
@zroubalik
Copy link
Member

zroubalik commented Jan 2, 2025

/run-e2e gcp
Update: You can check the progress here

Copy link
Member

@wozniakjan wozniakjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

minor nits below

pkg/scalers/gcp_stackdriver_scaler.go Outdated Show resolved Hide resolved
@wozniakjan
Copy link
Member

wozniakjan commented Jan 6, 2025

just noticed the imports are not sorted the way linter is configured, can you please run following command? (or address the imports sort manually :))

gci write . --skip-generated -s standard -s default -s prefix(github.com/kedacore/keda)

I will retrigger the e2e tests after that

omerap12 and others added 2 commits January 6, 2025 15:39
Co-authored-by: Jan Wozniak <[email protected]>
Signed-off-by: Omer Aplatony <[email protected]>
Signed-off-by: Omer Aplatony <[email protected]>
@omerap12
Copy link
Contributor Author

omerap12 commented Jan 6, 2025

just noticed the imports are not sorted the way linter is configured, can you please run following command? (or address the imports sort manually :))

gci write . --skip-generated -s standard -s default -s prefix(github.com/kedacore/keda)

I will retrigger the e2e tests after that

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants