Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Selenium Grid scaler logic on platformName is set empty or any #6477

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

VietND96
Copy link
Contributor

@VietND96 VietND96 commented Jan 9, 2025

When Node stereotype set "platformName": "" (empty), node started up and registered to Hub with converting to "platformName": "windows". Similarly, the same behavior in session capabilities. This unexpected behavior impacts the scaler in counting the pending and ongoing sessions.
This issue is fixed in Grid core SeleniumHQ/selenium#15036 (platformName is empty should be considered as enum ANY instead of WINDOWS). Available from 4.28.0 onwards.

The incoming request with setting capability "platformName": "any" or not set. It will be assigned to any Node with the stereotype platformName: any or not set.
So, updating the scaler condition to be aligned with the same behavior.

Checklist

Fixes #

Relates to #

@VietND96 VietND96 requested a review from a team as a code owner January 9, 2025 20:44
Signed-off-by: Viet Nguyen Duc <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant