WIP: Do Not Merge - Issue #6986 #7025
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a description of what has been changed
WIP, not to merge
This PR is to propose another way of solving the scale to 0 issue presented in #6986. The main point for this proposal is to not to change the GetPushScalers function, given that as a global function it might be used in other places in codebase and might affect functionality then. Instead, I propose to validate the scalingmodifiers cases inside the for loop in the goroutine, and each time and activeCh is triggered, it could evaluate the formula. Additionally, it might be good to consider the break task in the "active" conditional given that it might break in scaling from 0 scenarios.
Checklist
Fixes #
Relates to #6986