Skip to content

Conversation

ccjaimes
Copy link

Provide a description of what has been changed
WIP, not to merge

This PR is to propose another way of solving the scale to 0 issue presented in #6986. The main point for this proposal is to not to change the GetPushScalers function, given that as a global function it might be used in other places in codebase and might affect functionality then. Instead, I propose to validate the scalingmodifiers cases inside the for loop in the goroutine, and each time and activeCh is triggered, it could evaluate the formula. Additionally, it might be good to consider the break task in the "active" conditional given that it might break in scaling from 0 scenarios.

Checklist

Fixes #

Relates to #6986

Signed-off-by: Cristhian Peña <[email protected]>
Signed-off-by: Cristhian Peña <[email protected]>
Signed-off-by: Cristhian Peña <[email protected]>
@ccjaimes ccjaimes requested a review from a team as a code owner August 28, 2025 08:32
Copy link

Thank you for your contribution! 🙏

Please understand that we will do our best to review your PR and give you feedback as soon as possible, but please bear with us if it takes a little longer as expected.

While you are waiting, make sure to:

  • Add an entry in our changelog in alphabetical order and link related issue
  • Update the documentation, if needed
  • Add unit & e2e tests for your changes
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Once the initial tests are successful, a KEDA member will ensure that the e2e tests are run. Once the e2e tests have been successfully completed, the PR may be merged at a later date. Please be patient.

Learn more about our contribution guide.

@keda-automation keda-automation requested a review from a team August 28, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant