Skip to content

Conversation

drolando-stripe
Copy link

@drolando-stripe drolando-stripe commented Sep 2, 2025

We'd like to have a way to monitor the number of Keda errors due to empty responses from prometheus after enabling the ignoreNullValues flag for most of our prometheus triggers.

Right now this error gets logged but the error metric that Keda emits is generic and doesn't differentiate by error type.

Checklist

  • When introducing a new scaler, I agree with the scaling governance policy N/A
  • I have verified that my change is according to the deprecations & breaking changes policy
  • Tests have been added
  • Changelog has been updated and is aligned with our changelog requirements
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified) N/A
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #7062

Copy link

github-actions bot commented Sep 2, 2025

Thank you for your contribution! 🙏

Please understand that we will do our best to review your PR and give you feedback as soon as possible, but please bear with us if it takes a little longer as expected.

While you are waiting, make sure to:

  • Add an entry in our changelog in alphabetical order and link related issue
  • Update the documentation, if needed
  • Add unit & e2e tests for your changes
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Once the initial tests are successful, a KEDA member will ensure that the e2e tests are run. Once the e2e tests have been successfully completed, the PR may be merged at a later date. Please be patient.

Learn more about our contribution guide.

@keda-automation keda-automation requested review from a team September 2, 2025 22:24
@drolando-stripe drolando-stripe force-pushed the drolando/add_empty_response_metric branch from cd92291 to 316a7f8 Compare September 2, 2025 22:31
Signed-off-by: Daniele Rolando <[email protected]>
Signed-off-by: Daniele Rolando <[email protected]>
@drolando-stripe drolando-stripe force-pushed the drolando/add_empty_response_metric branch from 3f967e9 to 4a13d88 Compare September 3, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emit a metric tracking the number of empty responses from prometheus
1 participant