feedback#1
Open
muuu1321 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
フィードバック用。
このPRはマージしないでください。
自分の開発環境でprettierが動いてクォーテーションがシングルになったりしてます。
言語について
個人的にはtypescriptで書くのがお勧めです。
jsは実行しないとエラーかどうかわからない場合がありますが、tsは書いている時にエラーが出るので生産効率が良いです。
また、エディタの機能で変数の定義元に飛んだりできるので、コードが読みやすいです。
formatterとlinterについて
formatterとlinterを導入すると、lintルールから外れたコードにエラーを出したり、自動でコードを整形できます。
最近のチーム開発だとほぼ間違いなく導入されていると思います。
js, tsのformatter, linterの主流はpretter, eslintです。
↓vite環境下でのprettier, eslintの導入方法
https://zenn.dev/longbridge/articles/ae3aa36cf17d73