This repository has been archived by the owner on Nov 15, 2022. It is now read-only.
Fix OpenShift s2i tests: #584
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor changes to get the s2i tests working.
|
@surajnarwade review please :) |
|
@ashetty1 |
surajnarwade
reviewed
Feb 6, 2018
| func runKedgeS2i(imageName string, baseImage string) error { | ||
| s2iCmd := BinaryLocation + " build --s2i --image " + imageName + " -b " + baseImage | ||
| func runKedgeS2i(nameSpace string, baseImage string, contextDir string) error { | ||
| s2iCmd := BinaryLocation + " build --s2i --image " + nameSpace + "-img -b " + baseImage + |
There was a problem hiding this comment.
I think it should be,
s2iCmd := BinaryLocation + " build --s2i --image " + baseImage +" -c " + contextDir + " -n " + nameSpace
There was a problem hiding this comment.
Bit confused here, tests works fine locally:
$ make test-e2e-os
TEST=os make test-e2e
make[1]: Entering directory '/home/snarwade/go/src/github.com/kedgeproject/kedge'
./scripts/run_e2e.sh
======================================
| Running end-to-end cluster tests. |
| Tests will be ran against a k8s |
| cluster in separate namespaces |
| |
| Use command: |
| VERBOSE=yes make test-e2e-os |
| for verbosity. |
======================================
ok github.com/kedgeproject/kedge/tests/e2e 246.458s
make[1]: Leaving directory '/home/snarwade/go/src/github.com/kedgeproject/kedge'
There was a problem hiding this comment.
@surajnarwade the --image is for the name of the image to be generated. --baseimage is for baseimage.
|
@surajnarwade semaphore failing because of test run timeout, not because of individual tests failing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor changes to get the s2i tests working.