-
Notifications
You must be signed in to change notification settings - Fork 107
feat(datasets): Added the Experimental LangfuseTraceDataset #1208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks great!
Left two suggestions to double check.
kedro-datasets/kedro_datasets_experimental/langfuse/langfuse_trace_dataset.py
Show resolved
Hide resolved
kedro-datasets/kedro_datasets_experimental/langfuse/langfuse_trace_dataset.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
kedro-datasets/kedro_datasets_experimental/langfuse/langfuse_trace_dataset.py
Outdated
Show resolved
Hide resolved
kedro-datasets/kedro_datasets_experimental/langfuse/langfuse_trace_dataset.py
Outdated
Show resolved
Hide resolved
kedro-datasets/kedro_datasets_experimental/langfuse/langfuse_trace_dataset.py
Show resolved
Hide resolved
kedro-datasets/kedro_datasets_experimental/langfuse/langfuse_trace_dataset.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
kedro-datasets/kedro_datasets_experimental/langfuse/langfuse_trace_dataset.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @SajidAlamQB , Overall it looks good. I left few minor comments. Other than that it LGTM. Thank you
Signed-off-by: Sajid Alam <[email protected]>
Description
Related to: #1203
This PR adds
LangfuseTraceDatasetas an experimental dataset to enable Langfuse integration for tracing in Kedro pipelines. The implementation for this dataset can be found here: kedro-org/kedro-academy#77.The dataset provides three modes of integration:
langchain: Returns
CallbackHandlerfor LangChain tracingopenai: Returns wrapped OpenAI client with automatic tracing
sdk: Returns raw Langfuse client for manual instrumentation
Development notes
LangfuseTraceDatasettokedro_datasets_experimental.langfusemoduleChecklist
jsonschema/kedro-catalog-X.XX.jsonif necessaryRELEASE.mdfile