Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
f79f46d
Add credentials parameter to TableDataset for authentication
gitgud5000 Oct 19, 2025
1e65087
Add tests for TableDataset credentials functionality
gitgud5000 Oct 19, 2025
74cbed1
test(ibis): suppress false positive secret warning
gitgud5000 Oct 19, 2025
90db8d2
style(tests): apply lint and formatting fixes
gitgud5000 Oct 19, 2025
13e8b3b
fix(ibis): add credentials type validation to TableDataset. Appease m…
gitgud5000 Oct 19, 2025
bac6695
fix(ibis): Fix formatting and lint issues
gitgud5000 Oct 19, 2025
ce728b9
fix: secret false positive
gitgud5000 Oct 19, 2025
a7a3159
fix: formatting
gitgud5000 Oct 19, 2025
6bc347c
fix(tests): remove commented-out references from upstream examples
gitgud5000 Oct 19, 2025
9f68826
fix(RELEASE.md): update documentation for `ibis.TableDataset` with mo…
gitgud5000 Oct 19, 2025
59d72c5
fix: docs
gitgud5000 Oct 19, 2025
2f8d692
fix: docs...
gitgud5000 Oct 19, 2025
d1747ef
Merge branch 'kedro-org:main' into ibis-ds-credentials-support
gitgud5000 Oct 20, 2025
cdf8381
Merge branch 'main' into ibis-ds-credentials-support
deepyaman Oct 27, 2025
1071862
Address comments by @deepyaman: simplify `TableDataset` credentials m…
gitgud5000 Oct 28, 2025
cae37e8
fix credentials type annotation to resolves a mypy false positive.
gitgud5000 Oct 28, 2025
5397294
feat(schema): add optional credentials object to catalog JSON schema
gitgud5000 Oct 28, 2025
216cb26
fix test determine backend from dataset config and add credentials-ov…
gitgud5000 Oct 28, 2025
34af7b6
Merge branch 'main' into ibis-ds-credentials-support
deepyaman Oct 28, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions kedro-datasets/tests/ibis/test_table_dataset.py
Original file line number Diff line number Diff line change
Expand Up @@ -397,19 +397,20 @@ def test_connection_config(self, mocker, table_dataset, connection_config, key):
("database", ":memory:"),
),
),
(
{"backend": "duckdb", "database": "file.db"},
{"backend": "mssql", "password": "secret"}, # pragma: allowlist secret
(
("backend", "mssql"),
("database", "file.db"),
("password", "secret"),
),
),
],
indirect=["connection_config", "credentials_config"],
)
def test_connection_config_with_credentials(
self, mocker, table_dataset, connection_config, credentials_config, key
):
# Fix: handle non-dict connection_config/credentials_config
if isinstance(connection_config, dict) and "backend" in connection_config:
backend = connection_config["backend"]
elif isinstance(credentials_config, dict) and "backend" in credentials_config:
backend = credentials_config["backend"]
else:
backend = "duckdb"
def test_connection_config_with_credentials(self, mocker, table_dataset, key):
backend = table_dataset._connection_config["backend"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, much simpler. 🤦‍♂️

mocker.patch(f"ibis.{backend}")
table_dataset.load()
assert ("ibis", key) in table_dataset._connections
Expand Down
Loading