Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kedro viz --lite slowness #2271

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix kedro viz --lite slowness #2271

wants to merge 4 commits into from

Conversation

ravi-kumar-pilla
Copy link
Contributor

@ravi-kumar-pilla ravi-kumar-pilla commented Feb 12, 2025

Description

Resolves #2231

Development notes

  • Added spinner to show users a sign of processing
  • Added logic to ignore hidden files and gitignored files (Reused code of gitignore in autoreload done by @jitu5)
  • Updated log level to Warning as discussed
  • Updated tests

QA notes

  • All tests should pass

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

Signed-off-by: ravi_kumar_pilla <[email protected]>
Signed-off-by: ravi_kumar_pilla <[email protected]>
Signed-off-by: ravi_kumar_pilla <[email protected]>
@ravi-kumar-pilla ravi-kumar-pilla changed the title Fix viz --lite slowness Fix kedro viz --lite slowness Feb 12, 2025
@ravi-kumar-pilla ravi-kumar-pilla changed the title Fix kedro viz --lite slowness Fix kedro viz --lite slowness Feb 12, 2025
@ravi-kumar-pilla ravi-kumar-pilla marked this pull request as ready for review February 12, 2025 04:39
@rashidakanchwala
Copy link
Contributor

I noticed, the dataset type is now intergrations.UnavailableDataset on Kedro-Viz

Copy link
Contributor

@rashidakanchwala rashidakanchwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@astrojuanlu
Copy link
Member

How can we verify that this effectively solves the issue?

@ravi-kumar-pilla
Copy link
Contributor Author

How can we verify that this effectively solves the issue?

Hi @astrojuanlu , So the slowness might be due to many reasons but the issue's #2231 root cause is the parser parsing hidden files and gitignored files. This PR helps in resolving this issue. The test case here confirms it ignores hidden files.

If the slowness is reported again, then we can check for the cause and fix it. It would be hard to predict what might cause slowness without someone reporting bugs like #2231. Wdyt ?

@astrojuanlu
Copy link
Member

The test case here confirms it ignores hidden files.

Good 👍🏼

If the slowness is reported again [...]

Might be wiser to tell the user to try a pip install -e "kedro-viz @ git+..." and check for themselves, just to be 100 % sure, rather than waiting for a release to happen. Just a suggestion.

Code-wise I have nothing to say but also without a reproducer I can't QA this.

@ravi-kumar-pilla ravi-kumar-pilla mentioned this pull request Feb 19, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lite Viz is too slow
3 participants