Lets modernize! #418
Merged
Lets modernize! #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgraded node-sass and sharp and added a flag to `yarn install`.
This also required a couple upgrades of gatsby-remark related dependencies.
It's using an old version of sharp that's breaking cross-platform builds.
gatsby-plugin-favicon is deprecated and was causing all sorts of sharp versioning issues, while the manifest plugin is 1st-party and comes with localization functionality. Also untangled the resulting sharp version issues. This is the first time in years this repo has built cleanly on my machine.
mhluongo
force-pushed
the
lets-modernize
branch
from
d3222e8
to
96dfe43
Compare
Closed
|
Preview uploaded to https://preview.tbtc.network/lets-modernize/. |
Shadowfiend
reviewed
Aug 19, 2024
The build did it for unknown reasons. I gave up and committed them 😫 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If by modernize, of course, you actually mean upgrading the minimal number of dependencies to get a cross-platform build 🥲