Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add binary search algorithm #88

Merged
merged 10 commits into from
May 26, 2023
Merged

feat: Add binary search algorithm #88

merged 10 commits into from
May 26, 2023

Conversation

edisontim
Copy link
Contributor

@edisontim edisontim commented May 5, 2023 •
edited
Loading

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #87

What is the new behavior?

Adding binary search algorithm

Does this introduce a breaking change?

  • Yes
  • No

Other information

Added a searching directory in the repo
Resolves #87

@edisontim edisontim requested a review from 0xLucqs as a code owner May 5, 2023 09:36
@edisontim edisontim mentioned this pull request May 5, 2023
Closed
1 task
0xLucqs
0xLucqs requested changes May 5, 2023
View reviewed changes
Copy link
Collaborator

@0xLucqs 0xLucqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @wraitii

@edisontim
Copy link
Contributor Author

edisontim commented May 7, 2023 •
edited
Loading

Agree with @wraitii

Is this doable? I've asked on the cairo-1 Discord and the response was that all the methods of SpanTrait take a Span but not a U that implements SpanTrait. I believe that trait isn't implemented yet
https://discord.com/channels/793094838509764618/1065544063245365288/1104769573145812994

@wraitii
Copy link

wraitii commented May 8, 2023

Agree with @wraitii

Is this doable? I've asked on the cairo-1 Discord and the response was that all the methods of SpanTrait take a Span but not a U that implements SpanTrait. I believe that trait isn't implemented yet https://discord.com/channels/793094838509764618/1065544063245365288/1104769573145812994

Ah, you're right, it won't work at the moment, sorry.

@0xLucqs 0xLucqs merged commit d0b64d1 into keep-starknet-strange:main May 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wraitii wraitii wraitii left review comments

@gaetbout gaetbout gaetbout left review comments

@0xLucqs 0xLucqs 0xLucqs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Add binary search algorithm
4 participants
@edisontim @wraitii @gaetbout @0xLucqs