test cases for inter transfer #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #25 +/- ##
==========================================
+ Coverage 97.35% 98.67% +1.32%
==========================================
Files 5 5
Lines 378 378
==========================================
+ Hits 368 373 +5
+ Misses 10 5 -5 ☔ View full report in Codecov by Sentry. |
ZackAttax
requested changes
Feb 3, 2025
There was a problem hiding this comment.
I don't think we need to expose these private functions for testing. Check out these docs
https://book.cairo-lang.org/ch10-02-test-organization.html
ZackAttax
reviewed
Feb 3, 2025
tests/lib.cairo
Outdated
Comment on lines
972
to
985
| #[test] | ||
| #[should_panic(expected: 'Token ITR is paused')] | ||
| fn test_make_transfer_when_paused_neither_minter() { | ||
| let (tokenized_bond, minter) = setup_contract_with_minter(); | ||
| let from = address_with_tokens(tokenized_bond, minter); | ||
| let to = setup_receiver(); | ||
| let transfer = setup_transfer(from, to, AMOUNT_TRANSFERRED()); | ||
|
|
||
| start_cheat_caller_address(tokenized_bond.contract_address, OWNER()); | ||
| tokenized_bond.pause_inter_transfer(TOKEN_ID()); | ||
|
|
||
| start_cheat_caller_address(tokenized_bond.contract_address, from); | ||
| tokenized_bond.make_transfer(transfer); | ||
| } |
There was a problem hiding this comment.
we already have this same test on 891
There was a problem hiding this comment.
Oh damn. I had reviewed that. I totally forgot about it. removing it now
ZackAttax
reviewed
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.