Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): topology incidents #2961

Merged
merged 49 commits into from
Jan 13, 2025
Merged

feat(api): topology incidents #2961

merged 49 commits into from
Jan 13, 2025

Conversation

shahargl
Copy link
Member

@shahargl shahargl commented Jan 1, 2025

close #2984

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Jan 1, 2025
Copy link

vercel bot commented Jan 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keep ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 1:58pm

@dosubot dosubot bot added API API related issues Feature A new feature labels Jan 1, 2025
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Jan 1, 2025
Copy link

codecov bot commented Jan 1, 2025

Codecov Report

Attention: Patch coverage is 42.60870% with 66 lines in your changes missing coverage. Please review.

Project coverage is 31.23%. Comparing base (3e3a0e6) to head (d9c02c4).
Report is 30 commits behind head on main.

Files with missing lines Patch % Lines
keep/api/core/db.py 12.19% 36 Missing ⚠️
keep/rulesengine/rulesengine.py 33.33% 16 Missing ⚠️
keep/api/bl/enrichments_bl.py 37.50% 5 Missing ⚠️
keep/api/models/alert.py 69.23% 4 Missing ⚠️
keep/api/bl/incidents_bl.py 0.00% 3 Missing ⚠️
keep/api/models/db/alert.py 93.75% 1 Missing ⚠️
keep/api/tasks/process_event_task.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2961       +/-   ##
===========================================
- Coverage   43.52%   31.23%   -12.30%     
===========================================
  Files         165       70       -95     
  Lines       16250     7976     -8274     
===========================================
- Hits         7073     2491     -4582     
+ Misses       9177     5485     -3692     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

keep/api/core/tracer.py Show resolved Hide resolved
keep/api/core/db.py Show resolved Hide resolved
@talboren talboren merged commit 7b5af45 into main Jan 13, 2025
14 checks passed
@talboren talboren deleted the feature/apps branch January 13, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API API related issues Feature A new feature size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[➕ Feature]: Incident improvements
3 participants