-
Notifications
You must be signed in to change notification settings - Fork 785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): change calculation variable for pull data from providers #2962
Conversation
@00041275 is attempting to deploy a commit to the KeepHQ Team on Vercel. A member of the Team first needs to authorize it. |
Thank you for this PR again @00041275! What do you think if we add a backward compatibility for people who already use this with days? Do you have some idea? |
Really wish to see you in our Slack too! |
As you can see, I converted 7 days to minutes for backwards compatibility (check this). I didn't find any mention in the documentation part, so I consider this a rarely used feature. OLD:PROVIDER_PULL_INTERVAL_DAYS = int( NEW 7 days * 24 hour * 60 minute = 10 080PROVIDER_PULL_INTERVAL_MINUTE = int( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🎊 You're on fire, @00041275! Three PRs merged and counting! 🔥🎉 Your consistent contributions are truly impressive. You're becoming a valued member of our community! 💖 Remember, the team is always here to support you. Keep blazing that trail! 🚀 |
📑 Description
At the moment, keep prefers to work with webhook from source systems. But my company prefers to initiate a request from keep (for example, Oracle Enterprise Management). In view of this, it is problematic to have a limitation in a variable "KEEP_PULL_INTERVAL", which represents days. As more flexibility, it would be better to give users the ability to configure the pulling time themselves (for example, in minutes). Of course, ideally for the pull data option, it is best to have such a variable in the provider itself, but as an intermediate flexible solution, I suggest considering giving users the freedom to configure data collection from sources themselves.
✅ Checks
close #2975