fix: Fix broken provider images all around #3044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
size:L
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 2 different attempts to do it in the code:
keep/keep-ui/components/ui/DynamicIcon.tsx
Line 1 in 50e4caf
keep/keep-ui/components/ImageWithFallback.tsx
Line 4 in 50e4caf
But still![]()
without fallback is used all around the codebase and UI renders broken images:
Walked around the code and added fallback:
Main code here:
https://github.com/keephq/keep/pull/3044/files#diff-977bc09cad36ef884102415c92529e487305cc2e2aa1a8f88b8e587f625dab9c
Also changed some texts to close #3017