Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): saving workflow doesn't refresh cache #3336

Merged
merged 3 commits into from
Feb 6, 2025

Conversation

shahargl
Copy link
Member

@shahargl shahargl commented Feb 6, 2025

close #3335

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Feb 6, 2025
Copy link

vercel bot commented Feb 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keep ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 4:24pm

@dosubot dosubot bot added Bug Something isn't working UI User interface related issues labels Feb 6, 2025
Matvey-Kuk
Matvey-Kuk previously approved these changes Feb 6, 2025
Matvey-Kuk
Matvey-Kuk previously approved these changes Feb 6, 2025
talboren
talboren previously approved these changes Feb 6, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 6, 2025
@shahargl shahargl enabled auto-merge (squash) February 6, 2025 16:01
Copy link
Contributor

@Kiryous Kiryous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few comments

keep-ui/shared/ui/YAMLCodeblock/ui/MonacoYAMLEditor.tsx Outdated Show resolved Hide resolved
keep-ui/entities/workflows/model/useWorkflowActions.ts Outdated Show resolved Hide resolved
@shahargl shahargl dismissed stale reviews from talboren and Matvey-Kuk via a81b85c February 6, 2025 16:20
Copy link
Contributor

@Kiryous Kiryous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the edits

@shahargl shahargl merged commit 76c3fca into main Feb 6, 2025
11 checks passed
@shahargl shahargl deleted the bugfix/saveing-workflow branch February 6, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files. UI User interface related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: saving workflow does not refresh workflow
4 participants