fix(ui): Merge incidents not working in some cases #3456
Closed
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nayan-bagale is attempting to deploy a commit to the KeepHQ Team on Vercel. A member of the Team first needs to authorize it. |
dosubot
bot
added
the
size:XS
|
|
|
@nayan-bagale thank you for this contribution, but this was not the idea. I could've changed the toast to something else as well but what we want is to actually overcome the problem. There's another PR opened for that #3457 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/claim #3370
Closes #3370
📑 Description
✅ Checks
ℹ Additional Information
Before:
https://github.com/user-attachments/assets/6f564086-8e43-43b6-85e3-5247f4b0c6f8
After:
https://github.com/user-attachments/assets/4a45153c-a96d-4a04-82df-d0786fad2005
I've replaced
toast.successwith toast.info and passedresult.messageas an argument since the response contains a different message. A success toast isn't necessary in this case.