-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: incident merging #4058
fix: incident merging #4058
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the outcome of this PR, I don't understand what will happen with those skipped incidents?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4058 +/- ##
===========================================
- Coverage 47.03% 31.12% -15.92%
===========================================
Files 165 92 -73
Lines 16210 10060 -6150
===========================================
- Hits 7625 3131 -4494
+ Misses 8585 6929 -1656 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@talboren I removed skipped incidents, it will fail only on the case of exception. This PR will allow merging incidents without alerts & will fix the case when UI says incidents are merged but they are not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
close #3370