Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incident merging #4058

Merged
merged 13 commits into from
Mar 19, 2025
Merged

fix: incident merging #4058

merged 13 commits into from
Mar 19, 2025

Conversation

Matvey-Kuk
Copy link
Contributor

@Matvey-Kuk Matvey-Kuk commented Mar 16, 2025

close #3370

Copy link

vercel bot commented Mar 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keep ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2025 7:09pm

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. Bug Something isn't working Incident labels Mar 16, 2025
Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the outcome of this PR, I don't understand what will happen with those skipped incidents?

Copy link

codecov bot commented Mar 16, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 31.12%. Comparing base (d667aaf) to head (a2b0d49).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
keep/api/core/db.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4058       +/-   ##
===========================================
- Coverage   47.03%   31.12%   -15.92%     
===========================================
  Files         165       92       -73     
  Lines       16210    10060     -6150     
===========================================
- Hits         7625     3131     -4494     
+ Misses       8585     6929     -1656     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Matvey-Kuk
Copy link
Contributor Author

@talboren I removed skipped incidents, it will fail only on the case of exception. This PR will allow merging incidents without alerts & will fix the case when UI says incidents are merged but they are not.

Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 19, 2025
@Matvey-Kuk Matvey-Kuk merged commit ed2d815 into main Mar 19, 2025
15 checks passed
@Matvey-Kuk Matvey-Kuk deleted the Matvey-Kuk/fix-incident-merging branch March 19, 2025 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Incident lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Merge incidents not working in some cases
2 participants