Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Mitigate sort by last_received impact #4085

Merged
merged 48 commits into from
Mar 20, 2025
Merged

fix: Mitigate sort by last_received impact #4085

merged 48 commits into from
Mar 20, 2025

Conversation

skynetigor
Copy link
Contributor

Closes #4006

📑 Description

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

@vercel Vercel
Copy link

vercel bot commented Mar 17, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keep ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2025 5:49pm

skynetigor added 11 commits March 17, 2025 22:44
@skynetigor
fix: refactor alert query sorting logic and comment out unused code
a9b27e1
@skynetigor
fix: enhance alert query sorting by including LastAlert.alert_id for …
b63aaab 
…distinct results
@skynetigor
fix: remove LastAlert.alert_id from alert query sorting and distinct …
38e241b 
…logic
@skynetigor
fix: include LastAlert.alert_id in alert query sorting and distinct l…
6c695a5 
…ogic
@skynetigor
fix: add exists subquery to filter alerts by LastAlert tenant_id and …
a8768a1 
…alert_id
@skynetigor
fix: update filtering query to conditionally fetch incidents based on…
c9df640 
… input
@skynetigor
fix: modify total alerts query to conditionally count distinct alert_…
bc06ba5 
…ids based on incident fetching
@skynetigor
fix: disable incident enrichment in alert query and DTO conversion
873c049
@skynetigor
fix: enhance CEL to SQL conversion with result object and field remap…
5cc2c1a 
…ping functionality
@skynetigor
fix: enhance alert fetching logic with conditional joins and incident…
f206e39 
… enrichment
@skynetigor
Merge branch 'main' into mitigate-sort-by-last-received-impact
43a9741
@talboren talboren marked this pull request as ready for review March 20, 2025 17:42
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Mar 20, 2025
@dosubot dosubot bot added the Bug Something isn't working label Mar 20, 2025
talboren
talboren approved these changes Mar 20, 2025
View reviewed changes
Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 20, 2025
@skynetigor skynetigor merged commit 05d7595 into main Mar 20, 2025
17 of 19 checks passed
@skynetigor skynetigor deleted the mitigate-sort-by-last-received-impact branch March 20, 2025 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talboren talboren talboren approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: lastreceived sort not work, sorting is abnormal
2 participants
@skynetigor @talboren