-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Airflow provider integration and documentation #4090
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: tuantran0910 <[email protected]>
@tuantran0910 is attempting to deploy a commit to the KeepHQ Team on Vercel. A member of the Team first needs to authorize it. |
β€οΈ will review soon |
π |
Hi everyone, I'm facing the following issues:
Is this expected behavior, or am I missing something? Thanks in advance! |
Hey @tuantran0910, could be that there is some problem with the provider and it's not loading for some reason. |
Hi @talboren, I have figured out the reason that cannot making requests to the The only concern right now is that there is no ![]() There is not error log |
That's it, you found the reason :) Regarding not being able to see the provider in the list, it's because the provider doesn't really have any reason to be "installed" and we do not present it, because it has no configuration. I can actually see that the backend sends it to the frontend: But we do not present it because the provider has no configuration ^ this is an example from Pagerduty |
Thanks @talboren, I understand it. So because Airflow does not need to configure or install anything from the Keep side, so yeah, there is no reason to display it in the Providers page. |
Actually I think its cool to have it so people will know we have integration with them. There are couple of other providers that do not need any configuration but have provider tiles. For example, you can see |
I agree with @shahargl, we can put the instruction of how to setup the callback for Airflow that connect with Keep in here :D Maybe by adding three class variable |
That will be more than awesome |
Yeah, this can help the users to reduce the gap on exploring provider. I have configure this for the Airflow Provider :D ![]() Checkout this commit 7165b7c. |
@tuantran0910 regarding the but it can be configured later on "deduplication" rules, so let's start simple and continue from there? |
Totally agree @shahargl ! |
@tuantran0910 can you add a screenshot from provider screen to show how it looks like when you open Airflow? ππΌ |
Hi @talboren, here is the screenshot from the provider screen: ![]() Actually, I cannot click the block under the Linked Providers section, I have do search the ![]() Click on it under the Available Providers, then I got the information of the Airflow Provider: ![]() From my opinion, I think it would be ideal to let the user click on the block under Linked Providers :D Or maybe this is the default behavior in Keep. |
yea, currently "linkedin providers" aren't clickable (because they do not have any information/state). how would u change it? and apart from it - its ready for PR? |
Yes, it's ready for PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
Closes #4089
π Description
This PR is to add a feature for integration between Apache Airflow and Keep.
β Checks