fix: monaco from npm by default, CDN version in dev mode with turbopack #4105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Kiryous
changed the title
dosubot
bot
added
javascript
Signed-off-by: Kirill Chernakov <[email protected]>
…om:keephq/keep into fix/4104-monaco-editor-optional-npm-loader
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds support for loading Monaco Editor from NPM packages instead of CDN to support air-gapped environments, with several key changes to the codebase.
- Added new
MonacoEditorDefaultandMonacoEditorWithNpmcomponents in/keep-ui/shared/ui/MonacoEditor/to handle both CDN and NPM loading strategies - Added
MONACO_EDITOR_NPMconfiguration flag ingetConfig.tsto control editor loading method - Refactored workflow state management with new
isDeployedflag and proper null handling for timestamps - Replaced direct Monaco editor imports across multiple components with the new shared MonacoEditor component
- Modified
next.config.jsto support both webpack and turbo aliases for Monaco Editor NPM loading
21 file(s) reviewed, 6 comment(s)
Edit PR Review Bot Settings | Greptile
…n dev mode with turbopack
Kiryous
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4104