Merge pull request #239 from keepkey/bep2-rune

Adds BEP-2 support for Binance Chain
keepkey · Dec 1, 2020 · fb531bf · fb531bf
2 parents a988325 + 0f2917e
commit fb531bf
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
@@ -1 +1 @@
-* @keepkeyjon @markrypto
+* @markrypto
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -2,7 +2,7 @@ cmake_minimum_required(VERSION 3.7.2)
 
 project(KeepKeyFirmware
 
-        VERSION 6.5.1
+        VERSION 6.6.0
 
         LANGUAGES C CXX ASM)
 

diff --git a/deps/python-keepkey b/deps/python-keepkey
diff --git a/lib/firmware/fsm_msg_binance.h b/lib/firmware/fsm_msg_binance.h
@@ -101,8 +101,6 @@ void fsm_msgBinanceTransferMsg(const BinanceTransferMsg *msg) {
   CHECK_PARAM(msg->outputs[0].coins_count == 1, "Malformed BinanceTransferMsg")
   CHECK_PARAM(msg->inputs[0].coins[0].amount == msg->outputs[0].coins[0].amount,
               "Malformed BinanceTransferMsg")
-  CHECK_PARAM(strcmp(msg->inputs[0].coins[0].denom, "BNB") == 0,
-              "Other BNB tokens not yet supported")
   CHECK_PARAM(strcmp(msg->inputs[0].coins[0].denom,
                      msg->outputs[0].coins[0].denom) == 0,
               "Malformed BinanceTransferMsg")
@@ -136,8 +134,10 @@ void fsm_msgBinanceTransferMsg(const BinanceTransferMsg *msg) {
     }
     case OutputAddressType_TRANSFER:
     default: {
-      char amount_str[32];
-      bn_format_uint64(msg->outputs[0].coins[0].amount, NULL, " BNB", 8, 0,
+      char amount_str[42];
+      char denom_str[14];
+      snprintf(denom_str, strlen(msg->outputs[0].coins[0].denom) + 2, " %s", msg->outputs[0].coins[0].denom);
+      bn_format_uint64(msg->outputs[0].coins[0].amount, NULL, denom_str, 8, 0,
                        false, amount_str, sizeof(amount_str));
       if (!confirm_transaction_output(
               ButtonRequestType_ButtonRequest_ConfirmOutput, amount_str,
+1 −1		.circleci/config.yml
+35 −0		tests/test_msg_binance_sign_tx.py