bar-fmt 2/3: workspace integration — check recipes, editor wiring, migrate::stylua-cleanup - #3
Closed
keithharvey wants to merge 4 commits into
Closed
bar-fmt 2/3: workspace integration — check recipes, editor wiring, migrate::stylua-cleanup#3keithharvey wants to merge 4 commits into
keithharvey wants to merge 4 commits into
Conversation
keithharvey
force-pushed
the
bar-fmt-02-integration
branch
from
July 22, 2026 18:42
426a585 to
4a9e6f2
Compare
keithharvey
changed the title
keithharvey
marked this pull request as ready for review
July 22, 2026 19:36
This was referenced Jul 22, 2026
bar::check / bar::check-errors run emmylua_check inside bar-dev against BAR's .emmyrc.json; check-errors re-derives its exit code from the error count so warnings don't fail CI. Adds the devtools .emmyrc.json, points the VS Code template at the exported emmylua wrappers, extracts Sim/Units/Scripts docs in lua::library, and makes distrobox a hard setup requirement — the whole toolchain lives in the container. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
bar::codemod-build / codemod-test wrap codemod-cargo.sh. Migrations get their own bar::migrate:: namespace — adoption-dated entries listed in order, retired to [private] ~6 months after adoption. The 2026-07 stylua-cleanup entry replays the transform set (bracket-to-dot, rename-aliases, detach-bar-modules) plus stylua onto the local BAR checkout — the idempotent 'transform your branch, then merge' path the README callout documents. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The codemod scanned everything stylua ignores: .lux and
recoil-lua-library tool dirs, and mapgenerator — whose
mapinfo_template.lua is a ${}-placeholder template, not valid Lua.
Old runs never hit it because a local skip-worktree bit kept the file
off disk; upstream touched the file, checkout rewrote the index entry,
the bit dropped, and the template resurfaced as a parse failure.
Explicit excludes replace the hidden state. No output change: the
baseline transform chain has zero conversions under mapgenerator.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
keithharvey
force-pushed
the
bar-fmt-01-tooling
branch
from
July 23, 2026 01:38
7319515 to
93a9270
Compare
keithharvey
force-pushed
the
bar-fmt-02-integration
branch
from
July 23, 2026 01:38
b396e15 to
ac2c2bf
Compare
Owner
Author
|
Consolidating: bar-fmt reviews as one PR for now — the tip rollup at beyond-all-reason#57. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Layer 2 of the bar-fmt stack, on top of #2.
Consumer-side workspace integration:
bar::check/bar::check-errors(emmylua_check in bar-dev, exit code re-derived from the error count), the devtools.emmyrc.json, VS Code template wiring,lua::librarydoc-extraction updates, distrobox as a hard setup requirement, and the codemod recipes —bar::codemod-build/codemod-testplus the newbar::migrate::namespace. Migrations are adoption-dated and listed in order (ORM-style); the 2026-07stylua-cleanupentry is the idempotent 'transform your branch, then merge' replay the README callout documents. Entries retire to[private]~6 months after adoption. Includes the bifurcated-types design doc that motivates the whole effort.🤖 Generated with Claude Code