-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib-multisrc migration (draft for review) #1200
Conversation
9b6a4f5
to
2dcf20e
Compare
if (baseUrl.endsWith("/")) { | ||
println("::warning ::baseUrl[$baseUrl] has a trailing slash") | ||
} | ||
def split = baseUrl.split("://") | ||
assert split.length == 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think build should fail if baseUrl
contains anything after the domain. so http://example.com/something
or http://example.com/
all fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if the site hosts its manga reader in a subdirectory? https://example.com/something
should be valid IMO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If so, this field should be renamed to schemeWithDomain
or something. Some sources do require baseUrl
having more path segments or trailing slash. My intention was to keep this in sync with the one inside the source, and warn if someone updated both to have a trailing slash. This could be moved to some auditing script, etc. I'm open to suggestions.
References #265
See each commit for migration effect.
baseVersionCode
,overrideVersionCode
,themePkg