lib-multisrc migration (draft for review) #1200
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenyomi
force-pushed
the
lib-multisrc
branch
from
9b6a4f5
to
2dcf20e
Compare
Comment on lines
+43
to
+47
| if (baseUrl.endsWith("/")) { | ||
| println("::warning ::baseUrl[$baseUrl] has a trailing slash") | ||
| } | ||
| def split = baseUrl.split("://") | ||
| assert split.length == 2 |
There was a problem hiding this comment.
I think build should fail if baseUrl contains anything after the domain. so http://example.com/something or http://example.com/ all fail.
There was a problem hiding this comment.
What if the site hosts its manga reader in a subdirectory? https://example.com/something should be valid IMO.
There was a problem hiding this comment.
If so, this field should be renamed to schemeWithDomain or something. Some sources do require baseUrl having more path segments or trailing slash. My intention was to keep this in sync with the one inside the source, and warn if someone updated both to have a trailing slash. This could be moved to some auditing script, etc. I'm open to suggestions.
This was referenced Feb 13, 2024
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #265
See each commit for migration effect.
baseVersionCode,overrideVersionCode,themePkg