Added source multimanga #3631
Draft
Added source multimanga #3631
+450
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AwkwardPeak7
requested changes
Jun 20, 2024
src/ru/multimanga/src/eu/kanade/tachiyomi/extension/ru/multimanga/MultiManga.kt
Show resolved
Hide resolved
Comment on lines
+35
to
+41
| override fun popularMangaRequest(page: Int): Request { | ||
| return GET("$baseUrl", headers) | ||
| } | ||
|
|
||
| override fun latestUpdatesRequest(page: Int): Request { | ||
| return GET("$baseUrl", headers) | ||
| } |
There was a problem hiding this comment.
there is only like 5 items you are selecting from the front page for popular, it would be better to set supportslatest to false and return the whole page through popular alone
also, add the next page to the request, because currently you are requesting the same page over and over again
src/ru/multimanga/src/eu/kanade/tachiyomi/extension/ru/multimanga/MultiManga.kt
Show resolved
Hide resolved
src/ru/multimanga/src/eu/kanade/tachiyomi/extension/ru/multimanga/MultiManga.kt
Show resolved
Hide resolved
src/ru/multimanga/src/eu/kanade/tachiyomi/extension/ru/multimanga/MultiManga.kt
Show resolved
Hide resolved
| // chapter.name = urlElement.text() | ||
|
|
||
| val chapter = SChapter.create() | ||
| val loopbackUrl = urlElement.attr("href").removeRange(urlElement.attr("href").length - 3, urlElement.attr("href").length) |
There was a problem hiding this comment.
response.request.url.toString() will give you the current url.
also for future reference, check out StringKt documentation
it have methods like substringBeforeLast
src/ru/multimanga/src/eu/kanade/tachiyomi/extension/ru/multimanga/MultiManga.kt
Show resolved
Hide resolved
| return GET(page.imageUrl!!, newHeaders) | ||
| } | ||
|
|
||
| private class Genre(name: String, val id: String = name) : Filter.TriState(name) |
There was a problem hiding this comment.
use CheckBox filter. since you are not using exclude and include states
Add new line as requested Co-authored-by: AwkwardPeak7 <[email protected]>
As requested Co-authored-by: AwkwardPeak7 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3622 (previous pull) (I moved the branch so the pull request closed...)
closes #3498
Checklist:
extVersionCodevalue inbuild.gradlefor individual extensionsoverrideVersionCodeorbaseVersionCodeas needed for all multisrc extensionsisNsfw = trueflag inbuild.gradlewhen appropriateidif a source's name or language were changedweb_hi_res_512.pngwhen adding a new extension