-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Koharu #3981
Add Koharu #3981
Conversation
src/en/koharu/src/eu/kanade/tachiyomi/extension/en/koharu/Koharu.kt
Outdated
Show resolved
Hide resolved
src/en/koharu/src/eu/kanade/tachiyomi/extension/en/koharu/Koharu.kt
Outdated
Show resolved
Hide resolved
src/en/koharu/src/eu/kanade/tachiyomi/extension/en/koharu/Koharu.kt
Outdated
Show resolved
Hide resolved
src/en/koharu/src/eu/kanade/tachiyomi/extension/en/koharu/Koharu.kt
Outdated
Show resolved
Hide resolved
src/en/koharu/src/eu/kanade/tachiyomi/extension/en/koharu/Koharu.kt
Outdated
Show resolved
Hide resolved
- Fixed Filters/Search not working when query is empty - Changed image resolution default value to match website's - Use `when` instead of kotlin's reflect - Added search by "id", and url intent filter?
Can't get the URL intent filter to work. Testing with: adb shell am start -d "https://koharu.to/g/13922/e26c01a0810f" -a android.intent.action.VIEW You might need to set the extension as the default app for the Koharu domain, but I'm testing with "Better Open With". Searching for Stacktrace
|
src/en/koharu/src/eu/kanade/tachiyomi/extension/en/koharu/Koharu.kt
Outdated
Show resolved
Hide resolved
- Apply vetleledaal's suggestions - Fix UrlActivity?
Hello, I've changed the commited a change. Can you please test once again to see if it works? Thank you. |
It's working as expected now 🥳 One minor thing: CI is also failing on some lint issue. |
src/en/koharu/src/eu/kanade/tachiyomi/extension/en/koharu/Koharu.kt
Outdated
Show resolved
Hide resolved
src/en/koharu/src/eu/kanade/tachiyomi/extension/en/koharu/Koharu.kt
Outdated
Show resolved
Hide resolved
src/en/koharu/src/eu/kanade/tachiyomi/extension/en/koharu/KoharuDto.kt
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@mrtear @some-weeb-shit please stop "suggesting" enhancements like this, after the source is merged, you can open feature requests for anything you feel is missing. Commenting on prs like this and pinging contributors in issues can put unnecessary pressure on them, which may drive them away. |
Closes #3951
Checklist:
extVersionCode
value inbuild.gradle
for individual extensionsoverrideVersionCode
orbaseVersionCode
as needed for all multisrc extensionsisNsfw = true
flag inbuild.gradle
when appropriateid
if a source's name or language were changedweb_hi_res_512.png
when adding a new extension