Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Koharu #3981

Merged
merged 7 commits into from
Jul 16, 2024
Merged

Add Koharu #3981

merged 7 commits into from
Jul 16, 2024

Conversation

KenjieDec
Copy link
Contributor

Closes #3951

Checklist:

  • Updated extVersionCode value in build.gradle for individual extensions
  • Updated overrideVersionCode or baseVersionCode as needed for all multisrc extensions
  • Referenced all related issues in the PR body (e.g. "Closes #xyz")
  • Added the isNsfw = true flag in build.gradle when appropriate
  • Have not changed source names
  • Have explicitly kept the id if a source's name or language were changed
  • Have tested the modifications by compiling and running the extension through Android Studio
  • Have removed web_hi_res_512.png when adding a new extension

- Fixed Filters/Search not working when query is empty
- Changed image resolution default value to match website's
- Use `when` instead of kotlin's reflect
- Added search by "id", and url intent filter?
@vetleledaal
Copy link
Contributor

Can't get the URL intent filter to work. Testing with:

adb shell am start -d "https://koharu.to/g/13922/e26c01a0810f" -a android.intent.action.VIEW

You might need to set the extension as the default app for the Koharu domain, but I'm testing with "Better Open With". Searching for id:13922/e26c01a0810f works.

Stacktrace

2024-07-13 11:29:47.059  1580-2151  AiAiTranslate           com.google.android.as                I  C2T - not in a conversation
2024-07-13 11:29:47.120 30998-31033 EGL_emulation           com.aboutmycode.betteropenwith       D  app_time_stats: avg=362.98ms min=14.79ms max=5904.78ms count=17
2024-07-13 11:29:47.144   397-29401 audioserver             audioserver                          D  FGS Logger Transaction failed
2024-07-13 11:29:47.144 30998-30998 SQLiteAssetHelper       com.aboutmycode.betteropenwith       I  successfully opened database applist.db
2024-07-13 11:29:47.144   397-29401 audioserver             audioserver                          D  -129
2024-07-13 11:29:47.145   561-3152  Compatibil...geReporter system_server                        D  Compat change id reported: 161252188; UID 10472; state: DISABLED
2024-07-13 11:29:47.148   776-828   WindowManagerShell      com.android.systemui                 V  Transition requested: android.os.BinderProxy@b727261 TransitionRequestInfo { type = OPEN, triggerTask = TaskInfo{userId=0 taskId=86 displayId=0 isRunning=true baseIntent=Intent { act=android.intent.action.VIEW dat=https://koharu.to/... flg=0x13800000 cmp=eu.kanade.tachiyomi.extension.en.koharu/.KoharuUrlActivity } baseActivity=ComponentInfo{eu.kanade.tachiyomi.extension.en.koharu/eu.kanade.tachiyomi.extension.en.koharu.KoharuUrlActivity} topActivity=ComponentInfo{eu.kanade.tachiyomi.extension.en.koharu/eu.kanade.tachiyomi.extension.en.koharu.KoharuUrlActivity} origActivity=null realActivity=ComponentInfo{eu.kanade.tachiyomi.extension.en.koharu/eu.kanade.tachiyomi.extension.en.koharu.KoharuUrlActivity} numActivities=1 lastActiveTime=56460506 supportsMultiWindow=true resizeMode=1 isResizeable=true minWidth=-1 minHeight=-1 defaultMinSize=220 token=WCT{android.window.IWindowContainerToken$Stub$Proxy@69a7186} topActivityType=1 pictureInPictureParams=null shouldDockBigOverlays=false launchIntoPipHostTaskId=-1 lastParentTaskIdBeforePip=-1 displayCutoutSafeInsets=null topActivityInfo=ActivityInfo{1fd5a47 eu.kanade.tachiyomi.extension.en.koharu.KoharuUrlActivity} launchCookies=[] positionInParent=Point(0, 0) parentTaskId=-1 isFocused=false isVisible=false isVisibleRequested=false isSleeping=false topActivityInSizeCompat=false topActivityEligibleForLetterboxEducation= false topActivityLetterboxed= false isFromDoubleTap= false topActivityLetterboxVerticalPosition= -1 topActivityLetterboxHorizontalPosition= -1 topActivityLetterboxWidth=-1 topActivityLetterboxHeight=-1 locusId=null displayAreaFeatureId=1 cameraCompatControlState=hidden}, remoteTransition = null, displayChange = null }
2024-07-13 11:29:47.148   561-3152  ActivityTaskManager     system_server                        I  START u0 {act=android.intent.action.VIEW dat=https://koharu.to/... flg=0x13000000 cmp=eu.kanade.tachiyomi.extension.en.koharu/.KoharuUrlActivity} with LAUNCH_MULTIPLE from uid 10216 (BAL_ALLOW_VISIBLE_WINDOW) result code=0
2024-07-13 11:29:47.149   561-585   Compatibil...geReporter system_server                        D  Compat change id reported: 135634846; UID 10472; state: DISABLED
2024-07-13 11:29:47.149   561-585   Compatibil...geReporter system_server                        D  Compat change id reported: 177438394; UID 10472; state: DISABLED
2024-07-13 11:29:47.149   561-585   Compatibil...geReporter system_server                        D  Compat change id reported: 135772972; UID 10472; state: DISABLED
2024-07-13 11:29:47.149   561-585   Compatibil...geReporter system_server                        D  Compat change id reported: 135754954; UID 10472; state: ENABLED
2024-07-13 11:29:47.149   561-595   Compatibil...geReporter system_server                        D  Compat change id reported: 143937733; UID 10472; state: ENABLED
2024-07-13 11:29:47.152   357-357   Zygote                  pid-357                              D  Forked child process 2221
2024-07-13 11:29:47.153   561-595   ActivityManager         system_server                        I  Start proc 2221:eu.kanade.tachiyomi.extension.en.koharu/u0a472 for next-top-activity {eu.kanade.tachiyomi.extension.en.koharu/eu.kanade.tachiyomi.extension.en.koharu.KoharuUrlActivity}
2024-07-13 11:29:47.187  2221-2221  nsion.en.koharu         pid-2221                             I  Late-enabling -Xcheck:jni
2024-07-13 11:29:47.190   397-487   AudioFlinger            audioserver                          D  mixer(0x75fdca327930) throttle end: throttle time(33)
2024-07-13 11:29:47.197  2221-2221  nsion.en.koharu         pid-2221                             I  Using CollectorTypeCC GC.
2024-07-13 11:29:47.198  2221-2221  nsion.en.koharu         pid-2221                             W  Unexpected CPU variant for x86: x86_64.
                                                                                                    Known variants: atom, sandybridge, silvermont, goldmont, goldmont-plus, tremont, kabylake, default
2024-07-13 11:29:47.199   431-448   adbd                    adbd                                 I  jdwp connection from 2221
2024-07-13 11:29:47.228   561-3152  AppsFilter              system_server                        I  interaction: PackageSetting{4eb2811 eu.kanade.tachiyomi.extension.en.koharu/10472} -> PackageSetting{8b4a996 com.aboutmycode.betteropenwith/10216} BLOCKED
2024-07-13 11:29:47.232  2221-2221  Compatibil...geReporter pid-2221                             D  Compat change id reported: 171979766; UID 10472; state: ENABLED
2024-07-13 11:29:47.232  2221-2221  Compatibil...geReporter pid-2221                             D  Compat change id reported: 242716250; UID 10472; state: ENABLED
2024-07-13 11:29:47.236  2221-2221  ziparchive              pid-2221                             W  Unable to open '/data/app/~~mmN1YpL95QwI8Xih3e5PmQ==/eu.kanade.tachiyomi.extension.en.koharu-t67L43SUUCPuj9ESx8FCTg==/base.dm': No such file or directory
2024-07-13 11:29:47.236  2221-2221  ziparchive              pid-2221                             W  Unable to open '/data/app/~~mmN1YpL95QwI8Xih3e5PmQ==/eu.kanade.tachiyomi.extension.en.koharu-t67L43SUUCPuj9ESx8FCTg==/base.dm': No such file or directory
2024-07-13 11:29:47.237  2221-2221  nativeloader            pid-2221                             D  Configuring clns-6 for other apk /data/app/~~mmN1YpL95QwI8Xih3e5PmQ==/eu.kanade.tachiyomi.extension.en.koharu-t67L43SUUCPuj9ESx8FCTg==/base.apk. target_sdk_version=34, uses_libraries=, library_path=/data/app/~~mmN1YpL95QwI8Xih3e5PmQ==/eu.kanade.tachiyomi.extension.en.koharu-t67L43SUUCPuj9ESx8FCTg==/lib/x86_64, permitted_path=/data:/mnt/expand:/data/user/0/eu.kanade.tachiyomi.extension.en.koharu
2024-07-13 11:29:47.240  2221-2221  GraphicsEnvironment     pid-2221                             V  Currently set values for:
2024-07-13 11:29:47.240  2221-2221  GraphicsEnvironment     pid-2221                             V    angle_gl_driver_selection_pkgs=[]
2024-07-13 11:29:47.240  2221-2221  GraphicsEnvironment     pid-2221                             V    angle_gl_driver_selection_values=[]
2024-07-13 11:29:47.241  2221-2221  GraphicsEnvironment     pid-2221                             V  ANGLE GameManagerService for eu.kanade.tachiyomi.extension.en.koharu: false
2024-07-13 11:29:47.241  2221-2221  GraphicsEnvironment     pid-2221                             V  eu.kanade.tachiyomi.extension.en.koharu is not listed in per-application setting
2024-07-13 11:29:47.241  2221-2221  GraphicsEnvironment     pid-2221                             V  Neither updatable production driver nor prerelease driver is supported.
2024-07-13 11:29:47.243   561-3152  ActivityManager         system_server                        I  Flag disabled. Ignoring finishAttachApplication from uid: 10472. pid: 2221
2024-07-13 11:29:47.246  2221-2248  libEGL                  pid-2221                             D  loaded /vendor/lib64/egl/libEGL_emulation.so
2024-07-13 11:29:47.247  2221-2248  libEGL                  pid-2221                             D  loaded /vendor/lib64/egl/libGLESv1_CM_emulation.so
2024-07-13 11:29:47.248   400-400   BpBinder                surfaceflinger                       I  onLastStrongRef automatically unlinking death recipients: 
2024-07-13 11:29:47.249  2221-2248  libEGL                  pid-2221                             D  loaded /vendor/lib64/egl/libGLESv2_emulation.so
2024-07-13 11:29:47.252   561-934   ActivityTaskManager     system_server                        I  START u0 {act=android.intent.action.VIEW dat=https://koharu.to/... flg=0x13800000 cmp=eu.kanade.tachiyomi.extension.en.koharu/.KoharuUrlActivity} with LAUNCH_MULTIPLE from uid 10472 (BAL_ALLOW_VISIBLE_WINDOW) result code=2
2024-07-13 11:29:47.252   776-828   WindowManagerShell      com.android.systemui                 D  onActivityRestartAttempt: ComponentInfo{eu.kanade.tachiyomi.extension.en.koharu/eu.kanade.tachiyomi.extension.en.koharu.KoharuUrlActivity}
2024-07-13 11:29:47.255  2221-2221  nsion.en.koharu         pid-2221                             I  System.exit called, status: 0
2024-07-13 11:29:47.255  2221-2221  AndroidRuntime          pid-2221                             I  VM exiting with result code 0, cleanup skipped.
---------------------------- PROCESS STARTED (2221) for package eu.kanade.tachiyomi.extension.en.koharu ----------------------------
2024-07-13 11:29:47.259   561-934   ActivityManager         system_server                        I  Process eu.kanade.tachiyomi.extension.en.koharu (pid 2221) has died: fg  TOP 
2024-07-13 11:29:47.259   561-596   libprocessgroup         system_server                        I  Successfully killed process cgroup uid 10472 pid 2221 in 0ms
2024-07-13 11:29:47.259   357-357   Zygote                  pid-357                              I  Process 2221 exited cleanly (0)
2024-07-13 11:29:47.259   561-583   DisplayManagerService   system_server                        D  Drop pending events for gone uid 10472
2024-07-13 11:29:47.270  2022-2051  EGL_emulation           app.mihon.debug                      D  app_time_stats: avg=13219.45ms min=14.40ms max=277270.06ms count=21
2024-07-13 11:29:47.275   561-582   WindowManager           system_server                        V  Sent Transition #338 createdAt=07-13 11:29:47.146 via request=TransitionRequestInfo { type = OPEN, triggerTask = TaskInfo{userId=0 taskId=86 displayId=0 isRunning=true baseIntent=Intent { act=android.intent.action.VIEW dat=https://koharu.to/... flg=0x13800000 cmp=eu.kanade.tachiyomi.extension.en.koharu/.KoharuUrlActivity } baseActivity=ComponentInfo{eu.kanade.tachiyomi.extension.en.koharu/eu.kanade.tachiyomi.extension.en.koharu.KoharuUrlActivity} topActivity=ComponentInfo{eu.kanade.tachiyomi.extension.en.koharu/eu.kanade.tachiyomi.extension.en.koharu.KoharuUrlActivity} origActivity=null realActivity=ComponentInfo{eu.kanade.tachiyomi.extension.en.koharu/eu.kanade.tachiyomi.extension.en.koharu.KoharuUrlActivity} numActivities=1 lastActiveTime=56460506 supportsMultiWindow=true resizeMode=1 isResizeable=true minWidth=-1 minHeight=-1 defaultMinSize=220 token=WCT{RemoteToken{27abb38 Task{5a49069 #86 type=standard A=10472:eu.kanade.tachiyomi.extension.en.koharu}}} topActivityType=1 pictureInPictureParams=null shouldDockBigOverlays=false launchIntoPipHostTaskId=-1 lastParentTaskIdBeforePip=-1 displayCutoutSafeInsets=null topActivityInfo=ActivityInfo{89cf711 eu.kanade.tachiyomi.extension.en.koharu.KoharuUrlActivity} launchCookies=[] positionInParent=Point(0, 0) parentTaskId=-1 isFocused=false isVisible=false isVisibleRequested=false isSleeping=false topActivityInSizeCompat=false topActivityEligibleForLetterboxEducation= false topActivityLetterboxed= false isFromDoubleTap= false topActivityLetterboxVerticalPosition= -1 topActivityLetterboxHorizontalPosition= -1 topActivityLetterboxWidth=-1 topActivityLetterboxHeight=-1 locusId=null displayAreaFeatureId=1 cameraCompatControlState=hidden}, remoteTransition = null, displayChange = null }
2024-07-13 11:29:47.275   776-828   WindowManagerShell      com.android.systemui                 V  onTransitionReady android.os.BinderProxy@b727261: {id=338 t=OPEN f=0x0 trk=0 r=[0@Point(0, 0)] c=[{WCT{android.window.IWindowContainerToken$Stub$Proxy@7ab53e3} m=CHANGE f=MOVE_TO_TOP leash=Surface(name=Task=82)/@0x44b4274 sb=Rect(0, 0 - 1080, 2400) eb=Rect(0, 0 - 1080, 2400) d=0},{WCT{android.window.IWindowContainerToken$Stub$Proxy@c1411e0} m=CLOSE f=TRANSLUCENT leash=Surface(name=Task=85)/@0xc02d39d sb=Rect(0, 0 - 1080, 2400) eb=Rect(0, 0 - 1080, 2400) d=0}]}
2024-07-13 11:29:47.275   776-828   WindowManagerShell      com.android.systemui                 V  Playing animation for (#338)android.os.BinderProxy@b727261@0
2024-07-13 11:29:47.275   776-828   WindowManagerShell      com.android.systemui                 V   try handler com.android.wm.shell.transition.DefaultMixedHandler@346439c
2024-07-13 11:29:47.275   776-828   WindowManagerShell      com.android.systemui                 V   try handler com.android.wm.shell.keyguard.KeyguardTransitionHandler@42c81a5
2024-07-13 11:29:47.275   776-828   WindowManagerShell      com.android.systemui                 V   try handler com.android.wm.shell.activityembedding.ActivityEmbeddingController@111a97a
2024-07-13 11:29:47.275   776-828   WindowManagerShell      com.android.systemui                 V   try handler com.android.wm.shell.recents.RecentsTransitionHandler@484852b
2024-07-13 11:29:47.275   776-828   ShellRecents            com.android.systemui                 V  RecentsTransitionHandler.startAnimation: no controller found
2024-07-13 11:29:47.275   776-828   WindowManagerShell      com.android.systemui                 V   try handler com.android.wm.shell.pip.PipTransition@741fd88
2024-07-13 11:29:47.275   776-828   WindowManagerShell      com.android.systemui                 V   try handler com.android.wm.shell.splitscreen.StageCoordinator@1889321
2024-07-13 11:29:47.275   776-828   WindowManagerShell      com.android.systemui                 V   try handler com.android.wm.shell.transition.RemoteTransitionHandler@80e346
2024-07-13 11:29:47.275   561-582   WindowManager           system_server                        V      startWCT=WindowContainerTransaction { changes = {} hops = [] errorCallbackToken=null taskFragmentOrganizer=null }
2024-07-13 11:29:47.275   776-828   WindowManagerShell      com.android.systemui                 V  Transition doesn't have explicit remote, search filters for match for {id=338 t=OPEN f=0x0 trk=0 r=[0@Point(0, 0)] c=[{WCT{android.window.IWindowContainerToken$Stub$Proxy@7ab53e3} m=CHANGE f=MOVE_TO_TOP leash=Surface(name=Task=82)/@0x44b4274 sb=Rect(0, 0 - 1080, 2400) eb=Rect(0, 0 - 1080, 2400) d=0},{WCT{android.window.IWindowContainerToken$Stub$Proxy@c1411e0} m=CLOSE f=TRANSLUCENT leash=Surface(name=Task=85)/@0xc02d39d sb=Rect(0, 0 - 1080, 2400) eb=Rect(0, 0 - 1080, 2400) d=0}]}
2024-07-13 11:29:47.275   561-582   WindowManager           system_server                        V      info={id=338 t=OPEN f=0x0 trk=0 r=[0@Point(0, 0)] c=[{WCT{RemoteToken{cd5f962 Task{c295775 #82 type=standard A=10191:app.mihon.debug}}} m=CHANGE f=MOVE_TO_TOP leash=Surface(name=Task=82)/@0x5100744 sb=Rect(0, 0 - 1080, 2400) eb=Rect(0, 0 - 1080, 2400) d=0},{WCT{RemoteToken{7c3363e Task{7937b53 #85 type=standard A=10216:com.aboutmycode.betteropenwith}}} m=CLOSE f=TRANSLUCENT leash=Surface(name=Task=85)/@0x4c1df43 sb=Rect(0, 0 - 1080, 2400) eb=Rect(0, 0 - 1080, 2400) d=0}]}
2024-07-13 11:29:47.275   776-828   WindowManagerShell      com.android.systemui                 V   Checking filter Pair{{types=[] flags=0x0] notFlags=0x0 checks=[{atype=dream independent=true modes=[OPEN,TO_FRONT] flags=NONE mustBeTask=false order=ANY topActivity=null},{atype=home independent=true modes=[CLOSE,TO_BACK] flags=NONE mustBeTask=false order=ANY topActivity=null}]} RemoteTransition { remoteTransition = android.window.IRemoteTransition$Stub$Proxy@b134f70, appThread = android.app.IApplicationThread$Stub$Proxy@a0d22e9, debugName = LauncherToDream }}
2024-07-13 11:29:47.275   776-828   WindowManagerShell      com.android.systemui                 V   Checking filter Pair{{types=[] flags=0x0] notFlags=0x100 checks=[{atype=home independent=true modes=[OPEN,TO_FRONT] flags=NONE mustBeTask=false order=TOP topActivity=ComponentInfo{com.google.android.apps.nexuslauncher/com.google.android.apps.nexuslauncher.NexusLauncherActivity}},{atype=standard independent=true modes=[CLOSE,TO_BACK] flags=NONE mustBeTask=false order=ANY topActivity=null}]} RemoteTransition { remoteTransition = android.window.IRemoteTransition$Stub$Proxy@1710b6e, appThread = android.app.IApplicationThread$Stub$Proxy@3b1920f, debugName = QuickstepLaunchHome }}
2024-07-13 11:29:47.275   776-828   WindowManagerShell      com.android.systemui                 V   Delegate animation for #338 to null
2024-07-13 11:29:47.275   776-828   WindowManagerShell      com.android.systemui                 V   try handler com.android.wm.shell.transition.DefaultTransitionHandler@d526ea3
2024-07-13 11:29:47.275   776-828   WindowManagerShell      com.android.systemui                 V  start default transition animation, info = {id=338 t=OPEN f=0x0 trk=0 r=[0@Point(0, 0)] c=[{WCT{android.window.IWindowContainerToken$Stub$Proxy@7ab53e3} m=CHANGE f=MOVE_TO_TOP leash=Surface(name=Task=82)/@0x44b4274 sb=Rect(0, 0 - 1080, 2400) eb=Rect(0, 0 - 1080, 2400) d=0},{WCT{android.window.IWindowContainerToken$Stub$Proxy@c1411e0} m=CLOSE f=TRANSLUCENT leash=Surface(name=Task=85)/@0xc02d39d sb=Rect(0, 0 - 1080, 2400) eb=Rect(0, 0 - 1080, 2400) d=0}]}
2024-07-13 11:29:47.275   776-828   WindowManagerShell      com.android.systemui                 V  loadAnimation: anim=android.view.animation.AnimationSet@53e0c99 animAttr=0x7 type=OPEN isEntrance=false
2024-07-13 11:29:47.276   776-828   WindowManagerShell      com.android.systemui                 V   animated by com.android.wm.shell.transition.DefaultTransitionHandler@d526ea3
2024-07-13 11:29:47.282   561-934   ImeTracker              system_server                        I  app.mihon.debug:88d5dc07: onRequestHide at ORIGIN_SERVER_HIDE_INPUT reason HIDE_UNSPECIFIED_WINDOW
2024-07-13 11:29:47.282   561-934   ImeTracker              system_server                        I  app.mihon.debug:88d5dc07: onCancelled at PHASE_SERVER_SHOULD_HIDE
2024-07-13 11:29:47.283  1368-1368  GoogleInpu...hodService com...gle.android.inputmethod.latin  I  GoogleInputMethodService.onFinishInput():3157 
2024-07-13 11:29:47.283  1368-1368  GoogleInpu...hodService com...gle.android.inputmethod.latin  I  GoogleInputMethodService.updateDeviceLockedStatus():2248 repeatCheckTimes = 0, locked = false
2024-07-13 11:29:47.283  1368-1368  GoogleInpu...hodService com...gle.android.inputmethod.latin  I  GoogleInputMethodService.onStartInput():1986 onStartInput(EditorInfo{EditorInfo{packageName=app.mihon.debug, inputType=0, inputTypeString=NULL, enableLearning=false, autoCorrection=false, autoComplete=false, imeOptions=0, privateImeOptions=null, actionName=UNSPECIFIED, actionLabel=null, initialSelStart=-1, initialSelEnd=-1, initialCapsMode=0, label=null, fieldId=0, fieldName=null, extras=null, hintText=null, hintLocales=[]}}, false)
2024-07-13 11:29:47.283  1368-1368  GoogleInpu...hodService com...gle.android.inputmethod.latin  I  GoogleInputMethodService.updateDeviceLockedStatus():2248 repeatCheckTimes = 1, locked = false
2024-07-13 11:29:47.283  1368-1368  AndroidIME              com...gle.android.inputmethod.latin  I  InputBundleManager.loadActiveInputBundleId():450 loadActiveInputBundleId: und-Latn-x-password, password
2024-07-13 11:29:47.284   561-1889  PackageConfigPersister  system_server                        W  App-specific configuration not found for packageName: app.mihon.debug and userId: 0
2024-07-13 11:29:47.284   776-915   EGL_emulation           com.android.systemui                 D  app_time_stats: avg=960.68ms min=0.76ms max=7668.85ms count=8
2024-07-13 11:29:47.303   397-487   audioserver             audioserver                          D  FGS Logger Transaction failed
2024-07-13 11:29:47.303   397-487   audioserver             audioserver                          D  -129
2024-07-13 11:29:47.304   776-915   EGL_emulation           com.android.systemui                 D  app_time_stats: avg=364.05ms min=16.07ms max=6021.67ms count=18
2024-07-13 11:29:47.435   776-776   StatusBarIconController com.android.systemui                 D  ignoring old pipeline callbacks, because the new mobile icons are enabled
2024-07-13 11:29:47.632   776-828   WindowManagerShell      com.android.systemui                 V  Transition animation finished (aborted=false), notifying core (#338)android.os.BinderProxy@b727261@0
2024-07-13 11:29:47.632   561-582   WindowManager           system_server                        V  Finish Transition #338: created at 07-13 11:29:47.146 collect-started=0.021ms request-sent=1.765ms started=2.927ms ready=114.735ms sent=128.648ms finished=486.185ms
2024-07-13 11:29:47.633   776-828   WindowManagerShell      com.android.systemui                 V  Track 0 became idle
2024-07-13 11:29:47.633   776-828   WindowManagerShell      com.android.systemui                 V  All active transition animations finished
2024-07-13 11:29:47.649 30998-31033 OpenGLRenderer          com.aboutmycode.betteropenwith       D  endAllActiveAnimators on 0x7455b916e980 (ListView) with handle 0x7454591a3ec0
2024-07-13 11:29:47.658 30998-30998 WindowOnBackDispatcher  com.aboutmycode.betteropenwith       W  sendCancelIfRunning: isInProgress=falsecallback=android.view.ViewRootImpl$$ExternalSyntheticLambda17@44edf7e
2024-07-13 11:29:47.658   561-1889  CoreBackPreview         system_server                        D  Window{21fcda8 u0 com.aboutmycode.betteropenwith/com.aboutmycode.betteropenwith.SiteHandlerActivity EXITING}: Setting back callback null
2024-07-13 11:29:47.658   561-1889  InputManager-JNI        system_server                        W  Input channel object '21fcda8 com.aboutmycode.betteropenwith/com.aboutmycode.betteropenwith.SiteHandlerActivity (client)' was disposed without first being removed with the input manager!
2024-07-13 11:29:47.753   561-585   ActivityTaskManager     system_server                        W  Activity top resumed state loss timeout for ActivityRecord{d602f0 u0 eu.kanade.tachiyomi.extension.en.koharu/.KoharuUrlActivity t-1 f}}
2024-07-13 11:29:47.840   561-572   System                  system_server                        W  A resource failed to call HardwareBuffer.close. 
2024-07-13 11:29:47.840   561-572   System                  system_server                        W  A resource failed to call release. 
2024-07-13 11:29:47.840   561-572   System                  system_server                        W  A resource failed to call HardwareBuffer.close. 
2024-07-13 11:29:47.840   561-572   System                  system_server                        W  A resource failed to call release. 
2024-07-13 11:29:47.840   561-572   System                  system_server                        W  A resource failed to call HardwareBuffer.close. 
2024-07-13 11:29:47.840   561-572   System                  system_server                        W  A resource failed to call release. 
2024-07-13 11:29:47.840   561-572   System                  system_server                        W  A resource failed to call HardwareBuffer.close. 
2024-07-13 11:29:47.840   561-572   System                  system_server                        W  A resource failed to call HardwareBuffer.close. 

src/en/koharu/AndroidManifest.xml Outdated Show resolved Hide resolved
src/en/koharu/build.gradle Outdated Show resolved Hide resolved
- Apply vetleledaal's suggestions
- Fix UrlActivity?
@KenjieDec
Copy link
Contributor Author

Can't get the URL intent filter to work. Testing with:

adb shell am start -d "https://koharu.to/g/13922/e26c01a0810f" -a android.intent.action.VIEW

You might need to set the extension as the default app for the Koharu domain, but I'm testing with "Better Open With". Searching for id:13922/e26c01a0810f works.

Stacktrace

Hello, I've changed the commited a change. Can you please test once again to see if it works? Thank you.

@vetleledaal
Copy link
Contributor

Can you please test once again to see if it works?

It's working as expected now 🥳

One minor thing:
/g/.*/..* could be replaced with /g/..*/..* -- to ensure there is at least one character in that segment.

CI is also failing on some lint issue.

vetleledaal
vetleledaal previously approved these changes Jul 14, 2024
@some-weeb-shit

This comment has been minimized.

@mrtear

This comment has been minimized.

@AwkwardPeak7
Copy link
Contributor

@mrtear @some-weeb-shit please stop "suggesting" enhancements like this, after the source is merged, you can open feature requests for anything you feel is missing. Commenting on prs like this and pinging contributors in issues can put unnecessary pressure on them, which may drive them away.

@AwkwardPeak7 AwkwardPeak7 merged commit aa6ec47 into keiyoushi:main Jul 16, 2024
23 checks passed
@KenjieDec KenjieDec deleted the koharu branch July 16, 2024 11:33
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

koharu.to
5 participants