Removed restraints of maximum records and start record when using catalogus strategy and cleaned up tests to use one consistent style #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 23, 2021 15:22
…n using catalogus strategy and cleaned up tests.
…n using catalogus strategy and cleaned up tests.
…n using catalogus strategy and cleaned up tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when the catalogus website goes above page 100 it cant get the right records back due to startRecord and maximumRecords being above the allowed value.
To solve this I changed it so when using the Catalogus strategy the limitations on the maximum value gets ignored.
It should be looked into if keeping these limitations for other strategies is needed.
On top of that I renamed the tests to be more consistent with other projects and overall clearer as in the current situation they did no describe the tests clearly.