Skip to content

Commit

Permalink
Fix s3 bucket AccessControlListNotSupported error (#72)
Browse files Browse the repository at this point in the history
* Fix s3 bucket AccessControlListNotSupported error

* Apply depends_on to s3 bucket to prevent AccessControlListNotSupported
  • Loading branch information
jksprattler authored Sep 18, 2023
1 parent e7634c7 commit 1c92842
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions cloud_AWS/terraform/module/s3.tf
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ resource "aws_s3_bucket_acl" "acl" {
count = (var.s3_use_one_bucket == false ? length(var.vpc_id_list) : 1)
bucket = aws_s3_bucket.vpc_logs[count.index].id
acl = "private"
# This `depends_on` is to prevent "AccessControlListNotSupported: The bucket does not allow ACLs."
depends_on = [aws_s3_bucket_ownership_controls.ownership]
}

resource "aws_s3_bucket_policy" "policy" {
Expand All @@ -19,6 +21,14 @@ resource "aws_s3_bucket_policy" "policy" {
})
}

resource "aws_s3_bucket_ownership_controls" "ownership" {
count = (var.s3_use_one_bucket == false ? length(var.vpc_id_list) : 1)
bucket = aws_s3_bucket.vpc_logs[count.index].id
rule {
object_ownership = "ObjectWriter"
}
}

resource "aws_s3_bucket_public_access_block" "vpc_logs" {
count = (var.s3_use_one_bucket == false ? length(var.vpc_id_list) : 1)
bucket = aws_s3_bucket.vpc_logs[count.index].id
Expand Down

0 comments on commit 1c92842

Please sign in to comment.