Updates for jQuery 3.0+ and deprecations #4221
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replace $.type with `typeof`, `Array.isArray` or `$.isPlainObject` where needed
Fix invalid self-closing html tags
andrewcbi
approved these changes
Dec 6, 2022
|
@ahmadalfy can you check this? jQuery 4 completely removed support for the "$.type" and "$.isArray" functions used in slick's current code and this PR fixes them with their native equivalents. |
|
@pablo67340 This should be merged into next build. I've been using this in production since Dec 2022. |
markvantilburg
approved these changes
Sep 3, 2024
|
@ahmadalfy might be a good idea to merge this one and then check what is still missing comparing with #4007 #4071 is difficult to diff due to the changed spaces. |
This was referenced Oct 11, 2024
|
Can you please merge it, today slick is not working with jQuery 4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jQuery migrate warnings
$.typewithtypeof,Array.isArrayor$.isPlainObjectwhere appropriate.jQuery.fn.css( (property), value )slick.min.jswas not changed since it was still missing some previous changes to main file, it should probably just be re-minified.