Add bounce settings resource and data source for SendGrid #146
Conversation
- Implemented `sendgrid_bounce_settings` resource to manage bounce settings. - Added `sendgrid_bounce_settings` data source to retrieve current bounce settings. - Updated CHANGELOG.md to reflect new features. - Created documentation for both resource and data source. - Added tests for the new resource and data source.
There was a problem hiding this comment.
@DavidePrette Thank you for the pull request 🎉
The SendGrid client’s API handling is currently implemented in internal/provider/bounce_settings_client.go,
but all API-related logic should be implemented in kenzo0107/sendgrid.
Could you please move the implementation there instead?
- Remove internal bounce_settings_client.go implementation - Update bounce_settings_data_source.go to use sendgrid.Client.GetBounceSettings() - Update bounce_settings_resource.go to use sendgrid.Client.UpdateBounceSettings() - Remove dependency on custom ExtendClient pattern and environment variable requirements - Use local sendgrid library for testing via go.mod replace directive - Simplify implementation by leveraging standardized sendgrid library methods This migration moves the bounce settings API handling from the terraform provider to the sendgrid library where all API-related logic should be implemented.
The replace directive was used for local testing and is not needed for production.
|
Implementation moved: |
|
@DavidePrette It currently only supports soft_bounces, but hard_bounces should also be supported as an optional parameter, and enabled needs to be required. I have addressed these points in the following pull request: Also, although the default value for soft_bounces is set to 7 days, I couldn’t find a clear reason for that, so I believe it doesn’t need to be explicitly specified. As for the validation of the number of days specified for soft_bounces, it seems best to leave that to the API response, so no validation is implemented on the provider side. All of these updates have been handled in the following pull request: Your pull request greatly helped accelerate the development of the Bounce Settings feature. released by https://github.com/kenzo0107/terraform-provider-sendgrid/releases/tag/v2.4.0 |
2 participants
sendgrid_bounce_settingsresource to manage bounce settings.sendgrid_bounce_settingsdata source to retrieve current bounce settings.