-
Notifications
You must be signed in to change notification settings - Fork 44
Updated the index.html , add the new testimonial card , and uploaded … #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…the required image and it's css
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you and congratulations 🎉 for opening your very first pull request in student-program
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds a new testimonial card for Shravan Yadav under the "What do our previous fellows say?" section, updates the corresponding CSS, and includes the testimonial image.
- Inserted HTML markup for Shravan Yadav’s testimonial card in index.html
- Added
.div6styling in css/main.css for the new card - Uploaded
shravan.avifasset toimages/testimonials
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| index.html | Added Shravan Yadav testimonial card markup with image, name, role, GitHub link, and review text. |
| css/main.css | Defined .div6 selector to style the newly added testimonial card. |
Comments suppressed due to low confidence (2)
index.html:339
- [nitpick] Using the
designationclass for the GitHub link may cause styling conflicts; consider a more specific class (e.g.,profile-link).
<p class="designation">GitHub : <a href="https://github.com/Shravan9393"><u>https://github.com/Shravan9393</u></a></p>
css/main.css:2938
- [nitpick] The
.div6selector is generic; renaming to a semantic class (e.g.,.testimonial-card) would improve maintainability.
.div6 {
| <div class="div6 eachdiv"> | ||
| <div class="userdetails"> | ||
| <div class="imgbox"> | ||
| <img src="./images/testimonials/shravan.avif" alt=""> |
Copilot
AI
Jun 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a descriptive alt attribute (e.g., alt="Shravan Yadav photo") to improve accessibility.
| <img src="./images/testimonials/shravan.avif" alt=""> | |
| <img src="./images/testimonials/shravan.avif" alt="Shravan Yadav photo"> |
| </div> | ||
| <div class="review"> | ||
| <a href="#"> | ||
| <h4>From Keploy api fellowship program, my way of learning did take a new turn, as I got into expolring the open-source , reading the documents, and applying them to my projects.✨✨</h4> |
Copilot
AI
Jun 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix typo "expolring" to "exploring" in the testimonial text.
| <h4>From Keploy api fellowship program, my way of learning did take a new turn, as I got into expolring the open-source , reading the documents, and applying them to my projects.✨✨</h4> | |
| <h4>From Keploy api fellowship program, my way of learning did take a new turn, as I got into exploring the open-source , reading the documents, and applying them to my projects.✨✨</h4> |
| <a href="#"> | ||
| <h4>From Keploy api fellowship program, my way of learning did take a new turn, as I got into expolring the open-source , reading the documents, and applying them to my projects.✨✨</h4> | ||
| </a> |
Copilot
AI
Jun 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The anchor uses a placeholder href="#"; consider linking to the actual testimonial source or remove the link if not needed.
| <a href="#"> | |
| <h4>From Keploy api fellowship program, my way of learning did take a new turn, as I got into expolring the open-source , reading the documents, and applying them to my projects.✨✨</h4> | |
| </a> | |
| <h4>From Keploy api fellowship program, my way of learning did take a new turn, as I got into expolring the open-source , reading the documents, and applying them to my projects.✨✨</h4> |
|
Hey @Shravan9393, Thank you for raising the pr. As this is your submission for the API Fellowship, we are happy to see your work. Unfortunately we can not merge this pr as the typos are expected to be reported. We really appreciate your contribution. |
Description
Added A New Testimonal Card , Updates it's respective CSS , also uploaded the required display image for the Card.
This PR adds a new testimonial card for Shravan Yadav under the "What do our previous fellows say?" section on the Keploy Student Program webpage.
📌 Details:
Name: Shravan Yadav
Designation: Web Developer || Final Year || KIIT UNIVERSITY
GitHub: https://github.com/Shravan9393
Testimonial: "From Keploy api fellowship program, my way of learning did take a new turn, as I got into expolring the open-source , reading the documents, and applying them to my projects.✨✨"
This contribution is made as part of Task 2 of the Keploy API Fellowship.
Looking forward to your feedback! 🚀