Skip to content

Conversation

@Shravan9393
Copy link

Description

Added A New Testimonal Card , Updates it's respective CSS , also uploaded the required display image for the Card.

This PR adds a new testimonial card for Shravan Yadav under the "What do our previous fellows say?" section on the Keploy Student Program webpage.

📌 Details:

Name: Shravan Yadav
Designation: Web Developer || Final Year || KIIT UNIVERSITY
GitHub: https://github.com/Shravan9393
Testimonial: "From Keploy api fellowship program, my way of learning did take a new turn, as I got into expolring the open-source , reading the documents, and applying them to my projects.✨✨"

This contribution is made as part of Task 2 of the Keploy API Fellowship.

Looking forward to your feedback! 🚀

Copilot AI review requested due to automatic review settings June 18, 2025 17:59
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you and congratulations 🎉 for opening your very first pull request in student-program

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a new testimonial card for Shravan Yadav under the "What do our previous fellows say?" section, updates the corresponding CSS, and includes the testimonial image.

  • Inserted HTML markup for Shravan Yadav’s testimonial card in index.html
  • Added .div6 styling in css/main.css for the new card
  • Uploaded shravan.avif asset to images/testimonials

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.

File Description
index.html Added Shravan Yadav testimonial card markup with image, name, role, GitHub link, and review text.
css/main.css Defined .div6 selector to style the newly added testimonial card.
Comments suppressed due to low confidence (2)

index.html:339

  • [nitpick] Using the designation class for the GitHub link may cause styling conflicts; consider a more specific class (e.g., profile-link).
                <p class="designation">GitHub : <a href="https://github.com/Shravan9393"><u>https://github.com/Shravan9393</u></a></p>

css/main.css:2938

  • [nitpick] The .div6 selector is generic; renaming to a semantic class (e.g., .testimonial-card) would improve maintainability.
.div6 {

<div class="div6 eachdiv">
<div class="userdetails">
<div class="imgbox">
<img src="./images/testimonials/shravan.avif" alt="">
Copy link

Copilot AI Jun 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a descriptive alt attribute (e.g., alt="Shravan Yadav photo") to improve accessibility.

Suggested change
<img src="./images/testimonials/shravan.avif" alt="">
<img src="./images/testimonials/shravan.avif" alt="Shravan Yadav photo">

Copilot uses AI. Check for mistakes.
</div>
<div class="review">
<a href="#">
<h4>From Keploy api fellowship program, my way of learning did take a new turn, as I got into expolring the open-source , reading the documents, and applying them to my projects.✨✨</h4>
Copy link

Copilot AI Jun 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix typo "expolring" to "exploring" in the testimonial text.

Suggested change
<h4>From Keploy api fellowship program, my way of learning did take a new turn, as I got into expolring the open-source , reading the documents, and applying them to my projects.✨✨</h4>
<h4>From Keploy api fellowship program, my way of learning did take a new turn, as I got into exploring the open-source , reading the documents, and applying them to my projects.✨✨</h4>

Copilot uses AI. Check for mistakes.
Comment on lines +343 to +345
<a href="#">
<h4>From Keploy api fellowship program, my way of learning did take a new turn, as I got into expolring the open-source , reading the documents, and applying them to my projects.✨✨</h4>
</a>
Copy link

Copilot AI Jun 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The anchor uses a placeholder href="#"; consider linking to the actual testimonial source or remove the link if not needed.

Suggested change
<a href="#">
<h4>From Keploy api fellowship program, my way of learning did take a new turn, as I got into expolring the open-source , reading the documents, and applying them to my projects.✨✨</h4>
</a>
<h4>From Keploy api fellowship program, my way of learning did take a new turn, as I got into expolring the open-source , reading the documents, and applying them to my projects.✨✨</h4>

Copilot uses AI. Check for mistakes.
@pratik-mahalle
Copy link

pratik-mahalle commented Jun 23, 2025

Hey @Shravan9393, Thank you for raising the pr. As this is your submission for the API Fellowship, we are happy to see your work. Unfortunately we can not merge this pr as the typos are expected to be reported. We really appreciate your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants