fix(sdk build, package.json): Added .proto file as a part of build files and used it in grpc connection. #53
Conversation
|
Hi @Hermione2408, Please git rebase to pass DCO. You can follow the 3 steps mentioned in the failing DCO job |
|
I think that we should include .proto file in our "files" of package.json to include them in the npm build files. And use relative path to that for grpcClient connection. |
Hermione2408
changed the title
|
@re-Tick I have updated the PR with the changes Please review it and let me know if this need any changes. |
|
Hi @Hermione2408, Can we use the same "services.proto" file from photo directory instead of new "grpc.proto". |
…ndependent Previously we were using cp command to copy services.proto file from proto folder to dist folder but cp command doesnt work for windows and hence the build fails in windows. I added "copy-files" script which uses copyfiles npm module to copy proto file and is OS independent. fix #51 Signed-off-by: Hermione Dadheech <[email protected]>
…n build for grpc connection Added .proto file as a part of build file and used it in grpc connection. fix #51 Signed-off-by: Hermione Dadheech <[email protected]>
fix #51 Signed-off-by: Hermione Dadheech <[email protected]>
|
Hey @re-Tick do you mean something like this? |
|
Yes @Hermione2408. Have you built and tested your changes locally? LGTM. Please add the link to the PR in GSOC/2023 task list of typescript-sdk project. |
|
Yes I have built and tested my changes locally ,Its working fine. |
re-Tick
added
gsoc
re-Tick
added
Accepted
Previously we were using cp command to copy services.proto file from proto folder to dist folder but cp command doesnt work for windows and hence the build fails in windows. I added "copy-files" script which uses copyfiles npm module to copy proto file and is OS independent.
fix keploy/keploy#372