Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: record even on test mode #68

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

G0maa
Copy link
Contributor

@G0maa G0maa commented Mar 18, 2023

- Solves keploy/keploy#430
- Methodology: Treat as MODE_OFF in middleware and afterMiddleware functions

Signed-off-by: G0maa <[email protected]>
@developer-diganta
Copy link

@re-Tick Can you please review the PR?

@re-Tick
Copy link
Contributor

re-Tick commented Mar 20, 2023

LGTM. Please add PR link in the gsoc/2023 task list for respective issue.

@re-Tick re-Tick added Don't Merge Not to be merged until gsoc results Accepted PR is reviewed and Accepted labels Mar 20, 2023
@G0maa
Copy link
Contributor Author

G0maa commented Mar 20, 2023

Done: keploy/gsoc#46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted PR is reviewed and Accepted Don't Merge Not to be merged until gsoc results
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants