-
Notifications
You must be signed in to change notification settings - Fork 9
KEP 98: Promotion Phase for GitOps use cases #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| # Promotion Phase for GitOps use cases | ||
|
|
||
| Add a new lifecycle phase after post deployment dedicated to GitOps promotion tasks. | ||
|
|
||
| **State: DRAFTING** | ||
|
|
||
| ## Motivation | ||
|
|
||
| Since one of the main use cases for Keptn is enhancement of GitOps workflows, we should have bigger focus on that | ||
| by introducing a dedicated stage after the post-deployment phase for GitOps promotion tasks. | ||
mowies marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| This will make it much clearer for Keptn users how to set up their GitOps-assisted workflows in multi-stage | ||
| environments. | ||
|
|
||
| ## Explanation | ||
|
|
||
| The new promotion phase can be used by adding a list of references to `KeptnTaskDefinition` resources to a new field | ||
| called `promotionTasks` inside the `KeptnAppContext` CRD. Keptn will use this list the same way as for other phases | ||
| like post-deployment and execute the referenced tasks in parallel using Kubernetes Job resources. | ||
|
|
||
| ## Trade-offs and mitigations | ||
|
|
||
| No real drawbacks come to mind, except some slight slowdown in progression of the lifecycle since the new phase | ||
| needs to be executed and the lifecycle-operator needs to check if any tasks need to be run. | ||
|
|
||
| ## Breaking changes | ||
|
|
||
| This KEP would not have any breaking changes. The `KeptnAppContext` CRD would get an additional field called | ||
| `PromotionTasks` which contains a list of references to `KeptnTaskDefintion` resources that should be executed in this | ||
| phase. | ||
|
|
||
| ## Prior art and alternatives | ||
|
|
||
| The alternative to this KEP is that users re-purpose the post-deployment phase for promotion, which would limit | ||
| flexibility since users lose the option to not promote when post-deployment tasks fail. | ||
|
|
||
| ## Open questions | ||
|
|
||
| For now, none. | ||
mowies marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| ## Future possibilities | ||
|
|
||
| For now, none. | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.