-
Notifications
You must be signed in to change notification settings - Fork 9
KEP 89: Lifecycle Toolkit - Context Information in Keptn Tasks #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
thschue
wants to merge
3
commits into
main
Choose a base branch
from
kep/89
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,45 @@ | ||||||
| # KEP 89: Context Information in Keptn Tasks | ||||||
| **State: DRAFTING** | ||||||
|
|
||||||
| ## Dependencies | ||||||
| * This KEP depends on KEP88 which introduces instances of Keptn Workloads and Apps | ||||||
|
|
||||||
| ## Motivation | ||||||
| Currently, the lifecycle toolkit passes some context information (Workload, Application, Version) to the tasks. However, this information is not sufficient for promoting instances. As there should be a Keptn Task for promoting an instance, the context information should be extended to include the instance and a bit more information. | ||||||
|
|
||||||
| This KEP proposes the extension of passed context information. | ||||||
|
|
||||||
| ## Current Design | ||||||
| At the moment, the context information is passed as a JSON string in the `KEPTN_CONTEXT` environment variable. The JSON string contains the following information: | ||||||
| ```golang | ||||||
| type TaskContext struct { | ||||||
| WorkloadName string `json:"workloadName"` | ||||||
| AppName string `json:"appName"` | ||||||
| AppVersion string `json:"appVersion"` | ||||||
| WorkloadVersion string `json:"workloadVersion"` | ||||||
| TaskType string `json:"taskType"` | ||||||
| ObjectType string `json:"objectType"` | ||||||
| ``` | ||||||
|
|
||||||
| This information is passed to the tasks as a JSON string in the `KEPTN_CONTEXT` environment variable which can be used in the corresponding tasks. | ||||||
|
|
||||||
| ## Assumptions / Definitions | ||||||
| * It might be easier to pass over the whole KeptnAppVersion or KeptnWorkloadInstance as a JSON string instead of passing over the individual fields. | ||||||
| * There is no sensitive information in the context information | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would follow RFC2119 and have extra emphasis on this requirement
Suggested change
|
||||||
|
|
||||||
| ## Proposed Design | ||||||
| The proposed design is to pass over the whole KeptnAppVersion or KeptnWorkloadInstance Object as a JSON string in the `KEPTN_APP_CONTEXT` and `KEPTN_WORKLOAD_CONTEXT` environment variable. This would allow the tasks to access all information about the instance. Furthermore, annotations of the workload could be passed also as a JSON string in the `KEPTN_WORKLOAD_ANNOTATIONS` environment variable. | ||||||
|
|
||||||
| ## Benefits | ||||||
| * The tasks have access to all information about the application and workload | ||||||
| * The tasks can access the annotations of the workload | ||||||
| * Additional information would not have to be defined in the context information | ||||||
|
|
||||||
| ## Drawbacks | ||||||
| * The context information might be too big for some tasks | ||||||
| * The context information might contain sensitive information in the future which has to be filtered out | ||||||
|
|
||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.